You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Noorul Islam K M <no...@collab.net> on 2011/07/04 14:22:53 UTC
Re: Implement support for 'make check' variants
Noorul Islam K M <no...@collab.net> writes:
An update
> Daniel came up with idea of extending Makefile.in to support 'make
> check' variants.
>
> 1. 'make check' with svnserve -T
This was already implemented.
Completed testing using "make svnserveautocheck THREADED=1". I could not
see any errors.
> 2. 'make check' with svnadmin create --pre-1.x-compatible (where x in
> (1.4, 1.5, 1.6, 1.7))
This was already implemented.
make check SERVER_MINOR_VERSION=3.
I could see some failures. Are all the tests supposed to pass with this
kind of testing?
> 3. 'make check' with SVNPathAuthz short_circuit. As of now this is
> supported by stsp's Makefile.svn. So this will be bringing that into
> Makefile.in
>
Implemented and tested. No issues found while testing.
Thanks and Regards
Noorul
Re: Implement support for 'make check' variants
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Noorul Islam K M wrote on Tue, Jul 05, 2011 at 09:55:08 +0530:
> Daniel Shahaf <d....@daniel.shahaf.name> writes:
>
> > Noorul Islam K M wrote on Mon, Jul 04, 2011 at 17:52:53 +0530:
> >
> >> Noorul Islam K M <no...@collab.net> writes:
> >>
> >> An update
> >>
> >> > Daniel came up with idea of extending Makefile.in to support 'make
> >> > check' variants.
> >> >
> >> > 1. 'make check' with svnserve -T
> >>
> >> This was already implemented.
> >> Completed testing using "make svnserveautocheck THREADED=1". I could not
> >> see any errors.
> >>
> >> > 2. 'make check' with svnadmin create --pre-1.x-compatible (where x in
> >> > (1.4, 1.5, 1.6, 1.7))
> >>
> >> This was already implemented.
> >> make check SERVER_MINOR_VERSION=3.
> >> I could see some failures. Are all the tests supposed to pass with this
> >> kind of testing?
> >>
> >
> > If you see failures please report them on separate threads; they might
> > be shortcomings in the test suite, but let's confirm that.
> >
>
> I will do this.
>
> > By the way: according to my reading of the test suite's code, you should
> > have gotten an error message if you'd passed SERVER_MINOR_VERSION=3
> > (rather than 4 or bigger)! How come you didn't trigger the check in
> > svntest/main.py _parse_options()?
> >
>
> _parse_options() will not come into picture if we use 'make check'
> because we are directly calling svntest.main.execute_tests() from
> run_tests.py.
>
> I think we should patch run_tests.py to display error if the user passes
> values that is not in range 4 to 6.
>
> One more thing that I observed is that we are not supporting
> --pre-1.4-compatible option even though this one is available as an
> option to svnadmin command. See the snippet below. Is this intentional?
>
Feel free to add it and see what breaks...
(again, the SERVER_MINOR_VERSION options are used for two things, for
passing the --pre-1.x-compatible flag and for adjusting tests'
expectations when a 1.x.0 server is started *manually* to run the tests
against)
> <code>
> if options.server_minor_version < 5:
> opts += ("--pre-1.5-compatible",)
> elif options.server_minor_version < 6:
> opts += ("--pre-1.6-compatible",)
> elif options.server_minor_version < 7:
> opts += ("--pre-1.7-compatible",)
> if options.fs_type is not None:
> opts += ("--fs-type=" + options.fs_type,)
> exit_code, stdout, stderr = run_command(svnadmin_binary, 1, 0, "create",
> path, *opts)
> </code>
>
> Thanks and Regards
> Noorul
Re: Implement support for 'make check' variants
Posted by Noorul Islam K M <no...@collab.net>.
Daniel Shahaf <d....@daniel.shahaf.name> writes:
> Noorul Islam K M wrote on Mon, Jul 04, 2011 at 17:52:53 +0530:
>
>> Noorul Islam K M <no...@collab.net> writes:
>>
>> An update
>>
>> > Daniel came up with idea of extending Makefile.in to support 'make
>> > check' variants.
>> >
>> > 1. 'make check' with svnserve -T
>>
>> This was already implemented.
>> Completed testing using "make svnserveautocheck THREADED=1". I could not
>> see any errors.
>>
>> > 2. 'make check' with svnadmin create --pre-1.x-compatible (where x in
>> > (1.4, 1.5, 1.6, 1.7))
>>
>> This was already implemented.
>> make check SERVER_MINOR_VERSION=3.
>> I could see some failures. Are all the tests supposed to pass with this
>> kind of testing?
>>
>
> If you see failures please report them on separate threads; they might
> be shortcomings in the test suite, but let's confirm that.
>
I will do this.
> By the way: according to my reading of the test suite's code, you should
> have gotten an error message if you'd passed SERVER_MINOR_VERSION=3
> (rather than 4 or bigger)! How come you didn't trigger the check in
> svntest/main.py _parse_options()?
>
_parse_options() will not come into picture if we use 'make check'
because we are directly calling svntest.main.execute_tests() from
run_tests.py.
I think we should patch run_tests.py to display error if the user passes
values that is not in range 4 to 6.
One more thing that I observed is that we are not supporting
--pre-1.4-compatible option even though this one is available as an
option to svnadmin command. See the snippet below. Is this intentional?
<code>
if options.server_minor_version < 5:
opts += ("--pre-1.5-compatible",)
elif options.server_minor_version < 6:
opts += ("--pre-1.6-compatible",)
elif options.server_minor_version < 7:
opts += ("--pre-1.7-compatible",)
if options.fs_type is not None:
opts += ("--fs-type=" + options.fs_type,)
exit_code, stdout, stderr = run_command(svnadmin_binary, 1, 0, "create",
path, *opts)
</code>
Thanks and Regards
Noorul
Re: Implement support for 'make check' variants
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Noorul Islam K M wrote on Mon, Jul 04, 2011 at 17:52:53 +0530:
> Noorul Islam K M <no...@collab.net> writes:
>
> An update
>
> > Daniel came up with idea of extending Makefile.in to support 'make
> > check' variants.
> >
> > 1. 'make check' with svnserve -T
>
> This was already implemented.
> Completed testing using "make svnserveautocheck THREADED=1". I could not
> see any errors.
>
> > 2. 'make check' with svnadmin create --pre-1.x-compatible (where x in
> > (1.4, 1.5, 1.6, 1.7))
>
> This was already implemented.
> make check SERVER_MINOR_VERSION=3.
> I could see some failures. Are all the tests supposed to pass with this
> kind of testing?
>
If you see failures please report them on separate threads; they might
be shortcomings in the test suite, but let's confirm that.
By the way: according to my reading of the test suite's code, you should
have gotten an error message if you'd passed SERVER_MINOR_VERSION=3
(rather than 4 or bigger)! How come you didn't trigger the check in
svntest/main.py _parse_options()?
> > 3. 'make check' with SVNPathAuthz short_circuit. As of now this is
> > supported by stsp's Makefile.svn. So this will be bringing that into
> > Makefile.in
> >
>
> Implemented and tested. No issues found while testing.
>
Thanks.
> Thanks and Regards
> Noorul