You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Jiaqing Guo <gu...@cn.ibm.com> on 2014/11/29 08:43:45 UTC
Review Request 28534: gadget ifr servlet not able to refresh gadget
xml as desired
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28534/
-----------------------------------------------------------
Review request for shindig.
Summary (updated)
-----------------
gadget ifr servlet not able to refresh gadget xml as desired
Bugs: SHINDIG-1888
https://issues.apache.org/jira/browse/SHINDIG-1888
Repository: shindig
Description (updated)
-------
Copied from https://reviews.apache.org/r/10467/
Shindig ifr servlet entry will send the default cache control of gadget xml to the browser as a year by default. This is not reasonable especially when gadget xml resource server specified the cache control in its response to Shindig server, and consumer need to dynamically create the gadget xml content.
In the HttpCache of Shindig server, the gadget xml and its response are stored. The desired behavior would be to let the ifr servlet being able to refresh itself so the data in HttpCache can be validated, so a refetching of gadget xml can happen.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/containers/commoncontainer/GadgetXMLResponseWithCacheControl.jsp PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/content/containers/commoncontainer/gadgetCollections.json 1500152
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java 1372695
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java 1383189
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultMessageBundleFactory.java 1364210
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/Gadget.java 1364210
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java 1490276
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java 1454767
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java 1372888
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java 1452056
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingResults.java 1293966
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java 1364210
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java 1490276
Diff: https://reviews.apache.org/r/28534/diff/
Testing (updated)
-------
Done
Thanks,
Jiaqing Guo
Re: Review Request 28534: gadget ifr servlet not able to refresh
gadget xml as desired
Posted by Jiaqing Guo <gu...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28534/#review63282
-----------------------------------------------------------
As Ryan said in https://reviews.apache.org/r/10467/, I copied that review to this one and open it to shindig group for review.
- Jiaqing Guo
On 十一月 29, 2014, 7:43 a.m., Jiaqing Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28534/
> -----------------------------------------------------------
>
> (Updated 十一月 29, 2014, 7:43 a.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1888
> https://issues.apache.org/jira/browse/SHINDIG-1888
>
>
> Repository: shindig
>
>
> Description
> -------
>
> Copied from https://reviews.apache.org/r/10467/
> Shindig ifr servlet entry will send the default cache control of gadget xml to the browser as a year by default. This is not reasonable especially when gadget xml resource server specified the cache control in its response to Shindig server, and consumer need to dynamically create the gadget xml content.
>
> In the HttpCache of Shindig server, the gadget xml and its response are stored. The desired behavior would be to let the ifr servlet being able to refresh itself so the data in HttpCache can be validated, so a refetching of gadget xml can happen.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/containers/commoncontainer/GadgetXMLResponseWithCacheControl.jsp PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/containers/commoncontainer/gadgetCollections.json 1500152
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java 1372695
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java 1383189
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultMessageBundleFactory.java 1364210
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/Gadget.java 1364210
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java 1490276
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java 1454767
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java 1372888
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java 1452056
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingResults.java 1293966
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java 1364210
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java 1490276
>
> Diff: https://reviews.apache.org/r/28534/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Jiaqing Guo
>
>
Re: Review Request 28534: gadget ifr servlet not able to refresh
gadget xml as desired
Posted by Ryan Baxter <rb...@gmail.com>.
> On Dec. 1, 2014, 5:03 p.m., Ryan Baxter wrote:
> > My thoughts still apply to this, I think the API changes are not suitable for a point release.
>
> Jiaqing Guo wrote:
> Thank you for your comment, Ryan.
> So you means this patch is OK to you, but we might put it in a major release in the future, not a point release because this patch changes the API, is it right?
Thats correct.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28534/#review63379
-----------------------------------------------------------
On Nov. 29, 2014, 7:43 a.m., Jiaqing Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28534/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2014, 7:43 a.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1888
> https://issues.apache.org/jira/browse/SHINDIG-1888
>
>
> Repository: shindig
>
>
> Description
> -------
>
> Copied from https://reviews.apache.org/r/10467/
> Shindig ifr servlet entry will send the default cache control of gadget xml to the browser as a year by default. This is not reasonable especially when gadget xml resource server specified the cache control in its response to Shindig server, and consumer need to dynamically create the gadget xml content.
>
> In the HttpCache of Shindig server, the gadget xml and its response are stored. The desired behavior would be to let the ifr servlet being able to refresh itself so the data in HttpCache can be validated, so a refetching of gadget xml can happen.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/containers/commoncontainer/GadgetXMLResponseWithCacheControl.jsp PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/containers/commoncontainer/gadgetCollections.json 1500152
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java 1372695
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java 1383189
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultMessageBundleFactory.java 1364210
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/Gadget.java 1364210
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java 1490276
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java 1454767
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java 1372888
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java 1452056
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingResults.java 1293966
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java 1364210
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java 1490276
>
> Diff: https://reviews.apache.org/r/28534/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Jiaqing Guo
>
>
Re: Review Request 28534: gadget ifr servlet not able to refresh
gadget xml as desired
Posted by Jiaqing Guo <gu...@cn.ibm.com>.
> On 十二月 1, 2014, 5:03 p.m., Ryan Baxter wrote:
> > My thoughts still apply to this, I think the API changes are not suitable for a point release.
Thank you for your comment, Ryan.
So you means this patch is OK to you, but we might put it in a major release in the future, not a point release because this patch changes the API, is it right?
- Jiaqing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28534/#review63379
-----------------------------------------------------------
On 十一月 29, 2014, 7:43 a.m., Jiaqing Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28534/
> -----------------------------------------------------------
>
> (Updated 十一月 29, 2014, 7:43 a.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1888
> https://issues.apache.org/jira/browse/SHINDIG-1888
>
>
> Repository: shindig
>
>
> Description
> -------
>
> Copied from https://reviews.apache.org/r/10467/
> Shindig ifr servlet entry will send the default cache control of gadget xml to the browser as a year by default. This is not reasonable especially when gadget xml resource server specified the cache control in its response to Shindig server, and consumer need to dynamically create the gadget xml content.
>
> In the HttpCache of Shindig server, the gadget xml and its response are stored. The desired behavior would be to let the ifr servlet being able to refresh itself so the data in HttpCache can be validated, so a refetching of gadget xml can happen.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/containers/commoncontainer/GadgetXMLResponseWithCacheControl.jsp PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/containers/commoncontainer/gadgetCollections.json 1500152
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java 1372695
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java 1383189
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultMessageBundleFactory.java 1364210
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/Gadget.java 1364210
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java 1490276
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java 1454767
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java 1372888
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java 1452056
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingResults.java 1293966
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java 1364210
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java 1490276
>
> Diff: https://reviews.apache.org/r/28534/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Jiaqing Guo
>
>
Re: Review Request 28534: gadget ifr servlet not able to refresh
gadget xml as desired
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28534/#review63379
-----------------------------------------------------------
My thoughts still apply to this, I think the API changes are not suitable for a point release.
- Ryan Baxter
On Nov. 29, 2014, 7:43 a.m., Jiaqing Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28534/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2014, 7:43 a.m.)
>
>
> Review request for shindig.
>
>
> Bugs: SHINDIG-1888
> https://issues.apache.org/jira/browse/SHINDIG-1888
>
>
> Repository: shindig
>
>
> Description
> -------
>
> Copied from https://reviews.apache.org/r/10467/
> Shindig ifr servlet entry will send the default cache control of gadget xml to the browser as a year by default. This is not reasonable especially when gadget xml resource server specified the cache control in its response to Shindig server, and consumer need to dynamically create the gadget xml content.
>
> In the HttpCache of Shindig server, the gadget xml and its response are stored. The desired behavior would be to let the ifr servlet being able to refresh itself so the data in HttpCache can be validated, so a refetching of gadget xml can happen.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/containers/commoncontainer/GadgetXMLResponseWithCacheControl.jsp PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/content/containers/commoncontainer/gadgetCollections.json 1500152
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java 1372695
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java 1383189
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultMessageBundleFactory.java 1364210
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/Gadget.java 1364210
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java 1490276
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponseBuilder.java 1454767
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java 1372888
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java 1452056
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingResults.java 1293966
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java 1364210
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java 1490276
>
> Diff: https://reviews.apache.org/r/28534/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Jiaqing Guo
>
>