[GitHub] [iceberg] nastra commented on a change in pull request #4077: Build: Update spotless version and add spotless tasks

[GitBox <gi...@apache.org>]

nastra commented on a change in pull request #4077:
URL: https://github.com/apache/iceberg/pull/4077#discussion_r803475256



##########
File path: baseline.gradle
##########
@@ -48,6 +49,8 @@ subprojects {
   // import order.
   pluginManager.withPlugin('com.diffplug.spotless') {
     spotless {
+      // don't run spotlessCheck during gradle check task
+      enforceCheck = false

Review comment:
       so previously the gradle spotless plugin was already there, but never enabled. This PR enables it and makes sure it doesn't run during the normal `check` of Gradle because it will complain that the code format is off. 
   The implication of this is that we would run `spotlessCheck` / `spotlessApply` manually for now until the format of the codebase is in a state where we can enforce this on CI. Bringing the codebase into this state is what I wanted to focus on in a separate PR/discussion and I started already talking to @rdblue about it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org