You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2020/10/14 14:25:16 UTC

[GitHub] [avro] RyanSkraba commented on pull request #965: AVRO-2937: Add some missing options in SpecificCompilerTool

RyanSkraba commented on pull request #965:
URL: https://github.com/apache/avro/pull/965#issuecomment-708438641


   Hello!  I noticed that the flag names are different than the ones used in the schema compiler maven goal.  Do you think it's worthwhile trying to "unify" them?
   
   I _really_ like the separation into `CompilerOptions` for readability!  What do you think about moving it into the `SpecificCompiler` class directly, so it could be reused as "the source of truth" for configuration options and the Java code generation?
   
   I'm taking a look as it is, but I wanted to open the discussion -- thanks for proposing and implementing this feature!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org