[GitHub] [pinot] walterddr commented on a diff in pull request #9775: [multistage] [testing] Add join operator unit test and fix the bug when left join table is empty

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9775:
URL: https://github.com/apache/pinot/pull/9775#discussion_r1021736571


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##########
@@ -82,6 +90,8 @@ public HashJoinOperator(Operator<TransferableBlock> leftTableOperator, Operator<
     _isHashTableBuilt = false;
     _broadcastHashTable = new HashMap<>();
     _upstreamErrorBlock = null;
+    // TODO: Consider figuring out a better way to support join data left empty case.
+    _hasSentData = false;

Review Comment:
   i dont think this is actually a bug on the left empty or right empty. processing of a left or right empty block is the same as not-processing any block. and end-of-stream is a pass through. 
   
   I agree we should consolidate the behavior but let's not address this issue here and split into a separate PR



##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##########
@@ -48,9 +51,10 @@
  * We currently support left join, inner join and semi join.
  * The output is in the format of [left_row, right_row]
  */
+// TODO: Move inequi out of hashjoin. (https://github.com/apache/pinot/issues/9728)
 public class HashJoinOperator extends BaseOperator<TransferableBlock> {
-  private static final String EXPLAIN_NAME = "BROADCAST_JOIN";
-
+  private static final String EXPLAIN_NAME = "BROADCAST_HASH_JOIN";

Review Comment:
   ```suggestion
     private static final String EXPLAIN_NAME = "HASH_JOIN";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org