You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/25 02:59:16 UTC

[GitHub] [kafka] rodesai opened a new pull request #11805: KAFKA-13692: include metadata wait time in total blocked time

rodesai opened a new pull request #11805:
URL: https://github.com/apache/kafka/pull/11805


   This patch includes metadata wait time in total blocked time. First, this patch
   adds a new metric for total producer time spent waiting on metadata, called
   metadata-wait-time-ms-total. Then, this time is incldued in the total blocked
   time computed from StreamsProducer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cadonna commented on pull request #11805: KAFKA-13692: include metadata wait time in total blocked time

Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #11805:
URL: https://github.com/apache/kafka/pull/11805#issuecomment-1050598953


   @rodesai Some failures seem related.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang closed pull request #11805: KAFKA-13692: include metadata wait time in total blocked time

Posted by GitBox <gi...@apache.org>.
guozhangwang closed pull request #11805:
URL: https://github.com/apache/kafka/pull/11805


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on a change in pull request #11805: KAFKA-13692: include metadata wait time in total blocked time

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on a change in pull request #11805:
URL: https://github.com/apache/kafka/pull/11805#discussion_r832843342



##########
File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/KafkaProducerMetrics.java
##########
@@ -76,7 +75,7 @@ public KafkaProducerMetrics(Metrics metrics) {
         );
         metadataWaitSensor = newLatencySensor(
             METADATA_WAIT,
-            "Total time producer has spent waiting on metadata in "
+            "Total time producer has spent waiting on metadata on topic metadata."

Review comment:
       nit: dup words? Should it be "waiting on metadata in nanoseconds."?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on a change in pull request #11805: KAFKA-13692: include metadata wait time in total blocked time

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on a change in pull request #11805:
URL: https://github.com/apache/kafka/pull/11805#discussion_r814937598



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java
##########
@@ -223,7 +224,9 @@ private double totalBlockedTime(final Producer<?, ?> producer) {
             + getMetricValue(producer.metrics(), "txn-begin-time-ns-total")
             + getMetricValue(producer.metrics(), "txn-send-offsets-time-ns-total")
             + getMetricValue(producer.metrics(), "txn-commit-time-ns-total")
-            + getMetricValue(producer.metrics(), "txn-abort-time-ns-total");
+            + getMetricValue(producer.metrics(), "txn-abort-time-ns-total")

Review comment:
       This is a meta question: since ns and ms measurement mechanisms differ, if we simply sum them as `ns + ms * 10^6` it may not be accurate. Probably worth checking in if the aggregated total blocked time does make sense.

##########
File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/KafkaProducerMetrics.java
##########
@@ -71,6 +74,10 @@ public KafkaProducerMetrics(Metrics metrics) {
             TXN_ABORT,
             "Total time producer has spent in abortTransaction in nanoseconds."
         );
+        metadataWaitSensor = newLatencySensor(
+            METADATA_WAIT,
+            "Total time producer has spent waiting on metadata in "

Review comment:
       This line seems not completed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org