You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/12/13 03:24:30 UTC
[GitHub] [ozone] amaliujia opened a new pull request #1696: HDDS-4582 Update QUOTA_IN_COUNTS to quota in namespace
amaliujia opened a new pull request #1696:
URL: https://github.com/apache/ozone/pull/1696
## What changes were proposed in this pull request?
Use quota in namespace to improve readability of variables that are related to namespace quota.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4582
## How was this patch tested?
UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] captainzmc merged pull request #1696: HDDS-4582 Update `quota in counts` to `quota in namespace`
Posted by GitBox <gi...@apache.org>.
captainzmc merged pull request #1696:
URL: https://github.com/apache/ozone/pull/1696
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on a change in pull request #1696: HDDS-4582 Update `quota in counts` to `quota in namespace`
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #1696:
URL: https://github.com/apache/ozone/pull/1696#discussion_r542783447
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeSetQuotaRequest.java
##########
@@ -135,11 +135,12 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
} else {
omVolumeArgs.setQuotaInBytes(omVolumeArgs.getQuotaInBytes());
}
- if (checkQuotaCountsValid(setVolumePropertyRequest.getQuotaInCounts())) {
- omVolumeArgs.setQuotaInCounts(
- setVolumePropertyRequest.getQuotaInCounts());
+ if (checkQuotaCountsValid(
Review comment:
Indeed! Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #1696: HDDS-4582 Update `quota in counts` to `quota in namespace`
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1696:
URL: https://github.com/apache/ozone/pull/1696#issuecomment-744149930
Also R @captainzmc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] captainzmc commented on a change in pull request #1696: HDDS-4582 Update `quota in counts` to `quota in namespace`
Posted by GitBox <gi...@apache.org>.
captainzmc commented on a change in pull request #1696:
URL: https://github.com/apache/ozone/pull/1696#discussion_r542374089
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeSetQuotaRequest.java
##########
@@ -135,11 +135,12 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
} else {
omVolumeArgs.setQuotaInBytes(omVolumeArgs.getQuotaInBytes());
}
- if (checkQuotaCountsValid(setVolumePropertyRequest.getQuotaInCounts())) {
- omVolumeArgs.setQuotaInCounts(
- setVolumePropertyRequest.getQuotaInCounts());
+ if (checkQuotaCountsValid(
Review comment:
Do we also change checkQuotaCountsValid to checkQuotaNamespaceValid?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] captainzmc commented on pull request #1696: HDDS-4582 Update `quota in counts` to `quota in namespace`
Posted by GitBox <gi...@apache.org>.
captainzmc commented on pull request #1696:
URL: https://github.com/apache/ozone/pull/1696#issuecomment-745099965
Merged this. Thanks for @amaliujia's patch and @linyiqun's review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on a change in pull request #1696: HDDS-4582 Update `quota in counts` to `quota in namespace`
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #1696:
URL: https://github.com/apache/ozone/pull/1696#discussion_r542095753
##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/SetSpaceQuotaOptions.java
##########
@@ -32,14 +32,14 @@
@CommandLine.Option(names = {"--count-quota"},
description = "For volume this parameter represents the number of " +
Review comment:
Good point!
##########
File path: hadoop-ozone/dist/src/main/smoketest/basic/ozone-shell-lib.robot
##########
@@ -48,12 +48,12 @@ Test ozone shell
Should Be Equal ${result} DISK
${result} = Execute ozone sh bucket info ${protocol}${server}/${volume}/bb1 | jq -r '. | select(.name=="bb1") | .quotaInBytes'
Should Be Equal ${result} 10995116277760
- ${result} = Execute ozone sh bucket info ${protocol}${server}/${volume}/bb1 | jq -r '. | select(.name=="bb1") | .quotaInCounts'
+ ${result} = Execute ozone sh bucket info ${protocol}${server}/${volume}/bb1 | jq -r '. | select(.name=="bb1") | .quotaInNamespace'
Should Be Equal ${result} 100
Execute ozone sh bucket setquota ${protocol}${server}/${volume}/bb1 --space-quota 1TB --count-quota 1000
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #1696: HDDS-4582 Update QUOTA_IN_COUNTS to quota in namespace
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1696:
URL: https://github.com/apache/ozone/pull/1696#issuecomment-743958919
R: @linyiqun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] linyiqun commented on a change in pull request #1696: HDDS-4582 Update `quota in counts` to `quota in namespace`
Posted by GitBox <gi...@apache.org>.
linyiqun commented on a change in pull request #1696:
URL: https://github.com/apache/ozone/pull/1696#discussion_r542088595
##########
File path: hadoop-ozone/dist/src/main/smoketest/basic/ozone-shell-lib.robot
##########
@@ -48,12 +48,12 @@ Test ozone shell
Should Be Equal ${result} DISK
${result} = Execute ozone sh bucket info ${protocol}${server}/${volume}/bb1 | jq -r '. | select(.name=="bb1") | .quotaInBytes'
Should Be Equal ${result} 10995116277760
- ${result} = Execute ozone sh bucket info ${protocol}${server}/${volume}/bb1 | jq -r '. | select(.name=="bb1") | .quotaInCounts'
+ ${result} = Execute ozone sh bucket info ${protocol}${server}/${volume}/bb1 | jq -r '. | select(.name=="bb1") | .quotaInNamespace'
Should Be Equal ${result} 100
Execute ozone sh bucket setquota ${protocol}${server}/${volume}/bb1 --space-quota 1TB --count-quota 1000
Review comment:
Once option --count-quota is updated to --namespace-quota, this file also needed to be updated.
##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/SetSpaceQuotaOptions.java
##########
@@ -32,14 +32,14 @@
@CommandLine.Option(names = {"--count-quota"},
description = "For volume this parameter represents the number of " +
Review comment:
Can you also rename '--count-quota' to '--namespace-quota'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org