You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Babak Vahdat (Created) (JIRA)" <ji...@apache.org> on 2011/11/21 14:20:55 UTC

[jira] [Created] (CAMEL-4700) RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest

RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest
------------------------------------------------------------------------------------------------

                 Key: CAMEL-4700
                 URL: https://issues.apache.org/jira/browse/CAMEL-4700
             Project: Camel
          Issue Type: Task
          Components: camel-saxon
    Affects Versions: 2.9.0
            Reporter: Babak Vahdat
            Priority: Trivial
             Fix For: 2.9.0




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CAMEL-4700) RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest

Posted by "Hadrian Zbarcea (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hadrian Zbarcea resolved CAMEL-4700.
------------------------------------

    Resolution: Fixed

Thanks Babak for the contribution.
                
> RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest
> ------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4700
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4700
>             Project: Camel
>          Issue Type: Task
>          Components: camel-saxon
>    Affects Versions: 2.9.0
>            Reporter: Babak Vahdat
>            Assignee: Hadrian Zbarcea
>            Priority: Trivial
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4700.patch
>
>
> See http://camel.465427.n5.nabble.com/Unit-test-failure-on-trunk-in-camel-saxon-td5009713.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAMEL-4700) RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest

Posted by "Babak Vahdat (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Babak Vahdat updated CAMEL-4700:
--------------------------------

    Description: See http://camel.465427.n5.nabble.com/Unit-test-failure-on-trunk-in-camel-saxon-td5009713.html
    
> RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest
> ------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4700
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4700
>             Project: Camel
>          Issue Type: Task
>          Components: camel-saxon
>    Affects Versions: 2.9.0
>            Reporter: Babak Vahdat
>            Priority: Trivial
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4700.patch
>
>
> See http://camel.465427.n5.nabble.com/Unit-test-failure-on-trunk-in-camel-saxon-td5009713.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4700) RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest

Posted by "Willem Jiang (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154805#comment-13154805 ] 

Willem Jiang commented on CAMEL-4700:
-------------------------------------

@Hadrian,
I think the patch was truly fix the issue of SaxonInvalidXsltFileTest.
We need to do something from the side of xslt component itself.
You can find more information in this thread[1]

[1]http://camel.465427.n5.nabble.com/Unit-test-failure-on-trunk-in-camel-saxon-tp5009713p5010674.html

                
> RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest
> ------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4700
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4700
>             Project: Camel
>          Issue Type: Task
>          Components: camel-saxon
>    Affects Versions: 2.9.0
>            Reporter: Babak Vahdat
>            Assignee: Hadrian Zbarcea
>            Priority: Trivial
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4700.patch
>
>
> See http://camel.465427.n5.nabble.com/Unit-test-failure-on-trunk-in-camel-saxon-td5009713.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAMEL-4700) RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest

Posted by "Babak Vahdat (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Babak Vahdat updated CAMEL-4700:
--------------------------------

    Attachment: CAMEL-4700.patch
    
> RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest
> ------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4700
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4700
>             Project: Camel
>          Issue Type: Task
>          Components: camel-saxon
>    Affects Versions: 2.9.0
>            Reporter: Babak Vahdat
>            Priority: Trivial
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4700.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4700) RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest

Posted by "Hadrian Zbarcea (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154277#comment-13154277 ] 

Hadrian Zbarcea commented on CAMEL-4700:
----------------------------------------

@Babak, no worries. No need to apologize either, no 'rules' were broken and I don't think anybody is upset. My point is that Camel is big and we need to simplify wherever we can as things get harder to track. Users can help with that too.

I saw the priority and while one can filter based on it, the reality is that no one really does. Plus we are not all that consistent in using the priority for an issue (it would also hard, as 'priority' is in the eyes of the beholder.

@Babak, your contributions (not only this one!) are noted and highly appreciated.
                
> RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest
> ------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4700
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4700
>             Project: Camel
>          Issue Type: Task
>          Components: camel-saxon
>    Affects Versions: 2.9.0
>            Reporter: Babak Vahdat
>            Assignee: Hadrian Zbarcea
>            Priority: Trivial
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4700.patch
>
>
> See http://camel.465427.n5.nabble.com/Unit-test-failure-on-trunk-in-camel-saxon-td5009713.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (CAMEL-4700) RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest

Posted by "Hadrian Zbarcea (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hadrian Zbarcea reassigned CAMEL-4700:
--------------------------------------

    Assignee: Hadrian Zbarcea
    
> RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest
> ------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4700
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4700
>             Project: Camel
>          Issue Type: Task
>          Components: camel-saxon
>    Affects Versions: 2.9.0
>            Reporter: Babak Vahdat
>            Assignee: Hadrian Zbarcea
>            Priority: Trivial
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4700.patch
>
>
> See http://camel.465427.n5.nabble.com/Unit-test-failure-on-trunk-in-camel-saxon-td5009713.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CAMEL-4700) RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest

Posted by "Willem Jiang (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154805#comment-13154805 ] 

Willem Jiang edited comment on CAMEL-4700 at 11/22/11 2:18 AM:
---------------------------------------------------------------

@Hadrian,
I think the patch was not truly fix the issue of SaxonInvalidXsltFileTest.
We need to do something from the side of xslt component itself.
You can find more information in this thread[1]

[1]http://camel.465427.n5.nabble.com/Unit-test-failure-on-trunk-in-camel-saxon-tp5009713p5010674.html

                
      was (Author: njiang):
    @Hadrian,
I think the patch was truly fix the issue of SaxonInvalidXsltFileTest.
We need to do something from the side of xslt component itself.
You can find more information in this thread[1]

[1]http://camel.465427.n5.nabble.com/Unit-test-failure-on-trunk-in-camel-saxon-tp5009713p5010674.html

                  
> RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest
> ------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4700
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4700
>             Project: Camel
>          Issue Type: Task
>          Components: camel-saxon
>    Affects Versions: 2.9.0
>            Reporter: Babak Vahdat
>            Assignee: Hadrian Zbarcea
>            Priority: Trivial
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4700.patch
>
>
> See http://camel.465427.n5.nabble.com/Unit-test-failure-on-trunk-in-camel-saxon-td5009713.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4700) RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest

Posted by "Hadrian Zbarcea (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154814#comment-13154814 ] 

Hadrian Zbarcea commented on CAMEL-4700:
----------------------------------------

@Willem: I don't think so. I am aware of the thread, I just think nothing is broken. The issue was introduced in either r1201236 or r1202819 (didn't check exactly, but probably the latter) and the author probably only bothered to test camel-core, home of the XsltEndpoint, missing the side effect.

One feature added was the 'CamelXsltResourceUri' header, that allows one to specify an xslt stylesheet at runtime. You cannot necessarily assume that the xslt stylesheet passed as a header exists at route startup (could be for instance generated/copied by another route or process), but it must exists at the time the xslt endpoint processes the message. Now why would this be different for the stylesheet passed as an uri paramter? Another argument is that compiling the stylesheet is an expensive process and it doesn't need to be done until necessary. First use could happen much, much later after the route start and, again, the stylesheet may not be available when the route starts, but it would be available when the first message is received.

Of course, one could argue that if that is the case, one should use the 'CamelXsltResourceUri' header. There is no overhead, because stylesheets are cached. To me, however, the uri parameter is used a default when the header is not specified (convention over configuration) and the endpoint behavior is consistent the way it is now.
                
> RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest
> ------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4700
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4700
>             Project: Camel
>          Issue Type: Task
>          Components: camel-saxon
>    Affects Versions: 2.9.0
>            Reporter: Babak Vahdat
>            Assignee: Hadrian Zbarcea
>            Priority: Trivial
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4700.patch
>
>
> See http://camel.465427.n5.nabble.com/Unit-test-failure-on-trunk-in-camel-saxon-td5009713.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4700) RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest

Posted by "Jonathan Anstey (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155197#comment-13155197 ] 

Jonathan Anstey commented on CAMEL-4700:
----------------------------------------

FYI I added the fail-fast behavior back in http://svn.apache.org/viewvc?rev=1205032&view=rev so the test in Saxon was also reverted back. Thanks for taking the time to look into this Babak.

Cheers,
Jon
                
> RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest
> ------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4700
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4700
>             Project: Camel
>          Issue Type: Task
>          Components: camel-saxon
>    Affects Versions: 2.9.0
>            Reporter: Babak Vahdat
>            Assignee: Hadrian Zbarcea
>            Priority: Trivial
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4700.patch
>
>
> See http://camel.465427.n5.nabble.com/Unit-test-failure-on-trunk-in-camel-saxon-td5009713.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4700) RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest

Posted by "Hadrian Zbarcea (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154229#comment-13154229 ] 

Hadrian Zbarcea commented on CAMEL-4700:
----------------------------------------

I wonder why a new issue was open for this instead of just someone fixing the test or reopen the jira for which an improvement was made (and, well, not tested well enough). We used to have 200+ issues per minor release, then 300+, now 400+ and many of them are imho frivolous. The purpose of the bug tracking system is two-fold, one to keep track of issues for us, committers and second to communicate to users what is being done. This issue has no value for the latter and is redundant for the former, as jenkins will remind us of the issue every day until someone fixes it.

That said, I am looking into it now.
                
> RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest
> ------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4700
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4700
>             Project: Camel
>          Issue Type: Task
>          Components: camel-saxon
>    Affects Versions: 2.9.0
>            Reporter: Babak Vahdat
>            Assignee: Hadrian Zbarcea
>            Priority: Trivial
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4700.patch
>
>
> See http://camel.465427.n5.nabble.com/Unit-test-failure-on-trunk-in-camel-saxon-td5009713.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4700) RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest

Posted by "Babak Vahdat (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154274#comment-13154274 ] 

Babak Vahdat commented on CAMEL-4700:
-------------------------------------

@Hadrian,

it seems it was a fault of me to look at the dev forum and seeing the post submitted by Claus, and as I don't own SVN permission to commit any fix (I'm just a dummy Camel user), opening a ticket and providing a patch has been the way I've been through since my beginning with Camel. Please note that the type of this Ticket is "Task" with the priority "Trival".

So my apologies if I've broken any rules as a Apache Camel *user*.


                
> RegressionTest failure on camel-saxon @ org.apache.camel.component.xslt.SaxonInvalidXsltFileTest
> ------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4700
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4700
>             Project: Camel
>          Issue Type: Task
>          Components: camel-saxon
>    Affects Versions: 2.9.0
>            Reporter: Babak Vahdat
>            Assignee: Hadrian Zbarcea
>            Priority: Trivial
>             Fix For: 2.9.0
>
>         Attachments: CAMEL-4700.patch
>
>
> See http://camel.465427.n5.nabble.com/Unit-test-failure-on-trunk-in-camel-saxon-td5009713.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira