You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/03/03 14:26:53 UTC
[GitHub] [dubbo-go-samples] beiwei30 opened a new pull request #55: enhance async samples
beiwei30 opened a new pull request #55:
URL: https://github.com/apache/dubbo-go-samples/pull/55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] beiwei30 commented on a change in pull request #55: enhance async samples
Posted by GitBox <gi...@apache.org>.
beiwei30 commented on a change in pull request #55:
URL: https://github.com/apache/dubbo-go-samples/pull/55#discussion_r588170308
##########
File path: async/README.md
##########
@@ -1,24 +1,46 @@
-### Use Async Feature
+# Async Sample
-Implement this interface
+### Background
+
+Dubbo-go provides not only synchronous invocation, but also asynchronous invocation on the consumer side. In order to
+use it, the client needs to implement the following interface to asynchronously receive the response from the service
+provider:
```golang
-//AsyncCallbackService callback interface for async
type AsyncCallbackService interface {
- CallBack(response CallbackResponse) // callback
+CallBack(response CallbackResponse)
Review comment:
move back.
##########
File path: async/go-client/pkg/user.go
##########
@@ -18,11 +18,13 @@
package pkg
import (
- "context"
"github.com/apache/dubbo-go/common"
"github.com/apache/dubbo-go/protocol"
"github.com/apache/dubbo-go/remoting"
gxlog "github.com/dubbogo/gost/log"
+)
+import (
Review comment:
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] beiwei30 commented on a change in pull request #55: enhance async samples
Posted by GitBox <gi...@apache.org>.
beiwei30 commented on a change in pull request #55:
URL: https://github.com/apache/dubbo-go-samples/pull/55#discussion_r588167379
##########
File path: async/README.md
##########
@@ -1,24 +1,46 @@
-### Use Async Feature
+# Async Sample
-Implement this interface
+### Background
+
+Dubbo-go provides not only synchronous invocation, but also asynchronous invocation on the consumer side. In order to
+use it, the client needs to implement the following interface to asynchronously receive the response from the service
+provider:
```golang
-//AsyncCallbackService callback interface for async
type AsyncCallbackService interface {
- CallBack(response CallbackResponse) // callback
+CallBack(response CallbackResponse)
Review comment:
it's redundant, I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks merged pull request #55: enhance async samples
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #55:
URL: https://github.com/apache/dubbo-go-samples/pull/55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #55: enhance async samples
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #55:
URL: https://github.com/apache/dubbo-go-samples/pull/55#discussion_r587568363
##########
File path: async/README.md
##########
@@ -1,24 +1,46 @@
-### Use Async Feature
+# Async Sample
-Implement this interface
+### Background
+
+Dubbo-go provides not only synchronous invocation, but also asynchronous invocation on the consumer side. In order to
+use it, the client needs to implement the following interface to asynchronously receive the response from the service
+provider:
```golang
-//AsyncCallbackService callback interface for async
type AsyncCallbackService interface {
- CallBack(response CallbackResponse) // callback
+CallBack(response CallbackResponse)
Review comment:
why delete the blank and the comment here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #55: enhance async samples
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #55:
URL: https://github.com/apache/dubbo-go-samples/pull/55#discussion_r587569314
##########
File path: async/go-client/pkg/user.go
##########
@@ -18,11 +18,13 @@
package pkg
import (
- "context"
"github.com/apache/dubbo-go/common"
"github.com/apache/dubbo-go/protocol"
"github.com/apache/dubbo-go/remoting"
gxlog "github.com/dubbogo/gost/log"
+)
+import (
Review comment:
hey, guy, move this import block above as the first import block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org