You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/06/24 01:46:40 UTC

Review Request 22900: Modified two slave recovery tests to deal with the new subprocess based 'update' in network isolator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22900/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos-git


Description
-------

The update in network isolator launches a subprocess. Since now we wait for the update to finish before we send TASK_KILLED, we need to slightly change some existing tests to deal with that since clock is paused.


Diffs
-----

  src/tests/slave_recovery_tests.cpp 9274b1a 

Diff: https://reviews.apache.org/r/22900/diff/


Testing
-------

make check


Thanks,

Jie Yu


Re: Review Request 22900: Modified two slave recovery tests to deal with the new subprocess based 'update' in network isolator.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22900/#review46474
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On June 23, 2014, 11:46 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22900/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 11:46 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The update in network isolator launches a subprocess. Since now we wait for the update to finish before we send TASK_KILLED, we need to slightly change some existing tests to deal with that since clock is paused.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 9274b1a 
> 
> Diff: https://reviews.apache.org/r/22900/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>