[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38681: [SPARK-41165][CONNECT] Avoid hangs in the arrow collect code path

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #38681:
URL: https://github.com/apache/spark/pull/38681#discussion_r1024787984


##########
connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectServiceSuite.scala:
##########
@@ -55,4 +65,38 @@ class SparkConnectServiceSuite extends SharedSparkSession {
           && schema.getFields(1).getType.getKindCase == proto.DataType.KindCase.STRING)
     }
   }
+
+  test("failures in the arrow collect path should not cause hangs") {

Review Comment:
   nit
   ```suggestion
     test("SPARK-41165: failures in the arrow collect path should not cause hangs") {
   ```
   
   logic-wise, this is what I would do too. Looks good to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org