You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2023/02/09 11:03:44 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request, #7183: smoke test: fix test_vm_deployment_planner
weizhouapache opened a new pull request, #7183:
URL: https://github.com/apache/cloudstack/pull/7183
### Description
This PR fixes test failure with test_vm_deployment_planner
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7183: smoke test: fix test_vm_deployment_planner
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7183:
URL: https://github.com/apache/cloudstack/pull/7183#issuecomment-1424261114
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7183?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7183](https://codecov.io/gh/apache/cloudstack/pull/7183?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f27dbf) into [main](https://codecov.io/gh/apache/cloudstack/commit/1b89a22ab09045782fb438dd141eb0e1df39b9bb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b89a22) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #7183 +/- ##
=========================================
Coverage 12.63% 12.63%
Complexity 8613 8613
=========================================
Files 2711 2711
Lines 255752 255752
Branches 39873 39873
=========================================
Hits 32325 32325
Misses 219320 219320
Partials 4107 4107
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7183: smoke test: fix test_vm_deployment_planner
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7183:
URL: https://github.com/apache/cloudstack/pull/7183#discussion_r1101330313
##########
test/integration/smoke/test_vm_deployment_planner.py:
##########
@@ -69,7 +69,7 @@ def tearDownClass(cls):
cls
).getClsTestClient().getApiClient()
# Clean up, terminate the created templates
- cleanup_resources(cls.apiclient, cls.cleanup)
+ cleanup_resources(cls.apiclient, cls._cleanup)
except Exception as e:
raise Exception("Warning: Exception during cleanup : %s" % e)
Review Comment:
Let's replace tearDownClass with
```
@classmethod
def tearDownClass(cls):
cls.apiclient = super(TestVMDeploymentPlanner, cls).tearDownClass()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7183: smoke test: fix test_vm_deployment_planner
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7183:
URL: https://github.com/apache/cloudstack/pull/7183#issuecomment-1424141089
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7183)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7183&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7183&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7183&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7183&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7183&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7183&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7183&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7183&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7183&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7183&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7183&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7183&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7183&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7183&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7183: smoke test: fix test_vm_deployment_planner
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7183:
URL: https://github.com/apache/cloudstack/pull/7183#issuecomment-1424123854
simulator CI looks good now
```
2023-02-09T12:16:56.8399362Z ==== Marvin Init Started ====
2023-02-09T12:16:56.8399653Z
2023-02-09T12:16:56.8399865Z === Marvin Parse Config Successful ===
2023-02-09T12:16:56.8400126Z
2023-02-09T12:16:56.8400326Z === Marvin Setting TestData Successful===
2023-02-09T12:16:56.8400571Z
2023-02-09T12:16:56.8400857Z ==== Log Folder Path: /tmp/MarvinLogs/Feb_09_2023_12_16_03_TP0NMX All logs will be available here ====
2023-02-09T12:16:56.8401167Z
2023-02-09T12:16:56.8401355Z === Marvin Init Logging Successful===
2023-02-09T12:16:56.8401607Z
2023-02-09T12:16:56.8401791Z ==== Marvin Init Successful ====
2023-02-09T12:16:56.8402171Z === TestName: test_01_deploy_vm_on_specific_host | Status : SUCCESS ===
2023-02-09T12:16:56.8402445Z
2023-02-09T12:16:56.8402686Z === TestName: test_02_deploy_vm_on_specific_cluster | Status : SUCCESS ===
2023-02-09T12:16:56.8402961Z
2023-02-09T12:16:56.8403192Z === TestName: test_03_deploy_vm_on_specific_pod | Status : SUCCESS ===
2023-02-09T12:16:56.8403459Z
2023-02-09T12:16:56.8403716Z === TestName: test_04_deploy_vm_on_host_override_pod_and_cluster | Status : SUCCESS ===
2023-02-09T12:16:56.8404003Z
2023-02-09T12:16:56.8404427Z === TestName: test_05_deploy_vm_on_cluster_override_pod | Status : SUCCESS ===
2023-02-09T12:16:56.8404740Z
2023-02-09T12:16:56.8405008Z === Final results are now copied to: /tmp/MarvinLogs/test_vm_deployment_planner_UU7867 ===
2023-02-09T12:16:56.9048923Z
2023-02-09T12:16:56.9049346Z real 0m54.252s
2023-02-09T12:16:56.9049691Z user 0m0.997s
2023-02-09T12:16:56.9050447Z sys 0m0.068s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7183: smoke test: fix test_vm_deployment_planner
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7183:
URL: https://github.com/apache/cloudstack/pull/7183#issuecomment-1424263836
test code only proven by ci code looks good; merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7183: smoke test: fix test_vm_deployment_planner
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #7183:
URL: https://github.com/apache/cloudstack/pull/7183#discussion_r1101348742
##########
test/integration/smoke/test_vm_deployment_planner.py:
##########
@@ -69,7 +69,7 @@ def tearDownClass(cls):
cls
).getClsTestClient().getApiClient()
# Clean up, terminate the created templates
- cleanup_resources(cls.apiclient, cls.cleanup)
+ cleanup_resources(cls.apiclient, cls._cleanup)
except Exception as e:
raise Exception("Warning: Exception during cleanup : %s" % e)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7183: smoke test: fix test_vm_deployment_planner
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #7183:
URL: https://github.com/apache/cloudstack/pull/7183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org