You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/16 23:09:28 UTC
[GitHub] [druid] jihoonson commented on a change in pull request #10027: fix query memory leak
jihoonson commented on a change in pull request #10027:
URL: https://github.com/apache/druid/pull/10027#discussion_r441191277
##########
File path: processing/src/main/java/org/apache/druid/query/ChainedExecutionQueryRunner.java
##########
@@ -141,34 +142,38 @@ public ChainedExecutionQueryRunner(
);
}
)
- )
- );
+ );
- queryWatcher.registerQueryFuture(query, futures);
+ Function<Throwable, Void> cancelFunction = (t) -> {
Review comment:
I've been thinking about this, and it seems good to use `CompletableFuture` rather than having another home-grown util method for `ListenableFuture`. But it needs more work like how to support the query priority with `CompletableFuture`, it would be fine to add a util method for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org