You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Finn Isaac Norris Colman (JIRA)" <ji...@apache.org> on 2018/07/15 23:48:00 UTC

[jira] [Commented] (THRIFT-4600) Don't close the connection in flush for python THttpClient.py

    [ https://issues.apache.org/jira/browse/THRIFT-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544704#comment-16544704 ] 

Finn Isaac Norris Colman commented on THRIFT-4600:
--------------------------------------------------

PR for this is here:

https://github.com/apache/thrift/pull/1572

> Don't close the connection in flush for python THttpClient.py
> -------------------------------------------------------------
>
>                 Key: THRIFT-4600
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4600
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>    Affects Versions: 0.11.0
>            Reporter: Finn Isaac Norris Colman
>            Priority: Major
>             Fix For: 0.11.0
>
>
> In thrift/lib/py/src/transport/THttpClient.py in the flush method it closes and reopens the connection:
> {noformat}
> if self.isOpen():
>     self.close()
> self.open(){noformat}
>  
> This code is closing the connection on every flush request. The flush request occurs for every message send, which means that keep alive cannot be used. Removing this code from flush means that keep alive can be used as the user now has control over when the connection is closed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)