You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/30 06:34:13 UTC

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6942: ssvm: synchorise when adding iptables and routing rules

DaanHoogland commented on code in PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#discussion_r1059260056


##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##########
@@ -2225,7 +2225,7 @@ private String deleteLocalFile(String fullPath) {
         return null;
     }
 
-    public String allowOutgoingOnPrivate(String destCidr) {
+    public synchronized String allowOutgoingOnPrivate(String destCidr) {

Review Comment:
   @rohityadavcloud could you add a javadoc with the description and background?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org