[GitHub] [activemq-nms-amqp] Havret opened a new pull request #41: AMQNET-605: Pre-buffered messages shouldn't be released when consumer closes down

[GitBox <gi...@apache.org>]

Havret opened a new pull request #41: AMQNET-605: Pre-buffered messages shouldn't be released when consumer closes down
URL: https://github.com/apache/activemq-nms-amqp/pull/41
 
 
   This PR removes failing unit test, as we shouldn't support this scenario, hence this behavior is specific for _proton_ implementation and is not required by amq specification. 
   
   As a reference here's the discussion from dev mailing list discussing the issue:
   
   @Havret 
   > Hi guys,
   > 
   > We have an issue in NMS-AMQP https://issues.apache.org/jira/browse/AMQNET-605 which simply results in prefetched messages not being released after consumer closes down. I looked at it today, and it seems to be not as simple to fix as I expected.
   > We have one failing unit tests which was written based on qpid-jms implementation --> https://github.com/apache/activemq-nms-amqp/blob/65989e154c34c67b284c91b861d0ddc0a7c47b69/test/Apache-NMS-AMQP-Test/Integration/ConsumerIntegrationTest.cs#L235-L294
   > 
   > Can you please help mi to understand how it is possible to send release disposition after receiver link is closed? From what I've seen in qpid-jms there is no explicit disposition being send while receiver link is being closed. Therefore I assume proton must be sending this disposition implicitly. If so, my question is, whether this behavior meets the amqp spec. If so, I assume that AmqpNetLite which is our equivalent of proton, should mimic this behavior. 
   > 
   > Thanks,
   > Chris
   
   @gemmellr
   > It is proton that sends the disposition, as you assumed. The spec
   > allows for dispositions to be sent after links have detached, as the
   > deliveries can still be 'live' in some of these cases, but when it
   > occurs after the link is closed like below they actually have no
   > effect sincee the deliveries arent 'live' anymore as the link/terminus
   > is already gone. I wouldnt try to mimmick the behaviour, just delete
   > that test.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services