You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/10 13:37:47 UTC
[GitHub] [flink-table-store] Gerrrr opened a new pull request, #372: [FLINK-29962] Exclude jamon 2.3.1 from dependencies
Gerrrr opened a new pull request, #372:
URL: https://github.com/apache/flink-table-store/pull/372
Flink Table Store has the [same issue](https://issues.apache.org/jira/browse/FLINK-29962) as the main repo - hive dependencies depend on `jamon-runtime-2.3.1` that has malformed [pom](https://repo1.maven.org/maven2/org/jamon/jamon-runtime/2.3.1/jamon-runtime-2.3.1.pom) (nested project tag). My maven mirror complains about this and does not accept the dependency. Here is an error message:
```
Could not resolve dependencies for project org.apache.flink:flink-table-store-hive-catalog:jar:0.3-SNAPSHOT: Failed to collect dependencies at org.apache.hive.hcatalog:hive-webhcat-java-client:jar:2.3.9 -> org.apache.hive.hcatalog:hive-hcatalog-core:jar:2.3.9 -> org.apache.hive:hive-cli:jar:2.3.9 -> org.apache.hive:hive-service:jar:2.3.9 -> org.apache.hive:hive-llap-server:jar:2.3.9 -> org.apache.hbase:hbase-server:jar:1.1.1 -> org.jamon:jamon-runtime:jar:2.3.1: Failed to read artifact descriptor for org.jamon:jamon-runtime:jar:2.3.1: Could not transfer artifact org.jamon:jamon-runtime:pom:2.3.1 from/to confluent-artifactory-central (<mirror url>): transfer failed for <mirror url>/org/jamon/jamon-runtime/2.3.1/jamon-runtime-2.3.1.pom, status: 409 Conflict -> [Help 1]
```
This PR excludes the transitive dependency from the problematic direct dependencies and pins the dependency to 2.4.1.
Kudos to @vvcephei for coming up with the original fix for the main repository.
@JingsongLi Can you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] Gerrrr commented on a diff in pull request #372: [FLINK-29962] Exclude jamon 2.3.1 from dependencies
Posted by GitBox <gi...@apache.org>.
Gerrrr commented on code in PR #372:
URL: https://github.com/apache/flink-table-store/pull/372#discussion_r1019275378
##########
flink-table-store-hive/flink-table-store-hive-catalog/pom.xml:
##########
@@ -86,6 +86,12 @@ under the License.
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.jamon</groupId>
+ <artifactId>jamon-runtime</artifactId>
+ <version>2.4.1</version>
+ </dependency>
+
Review Comment:
I removed that and my build succeeded locally. Thank you for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] vvcephei commented on pull request #372: [FLINK-29962] Exclude jamon 2.3.1 from dependencies
Posted by GitBox <gi...@apache.org>.
vvcephei commented on PR #372:
URL: https://github.com/apache/flink-table-store/pull/372#issuecomment-1310364897
Thanks for this, @Gerrrr !
FYI, here's the other PR: https://github.com/apache/flink/pull/21278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on pull request #372: [FLINK-29962] Exclude jamon 2.3.1 from dependencies
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on PR #372:
URL: https://github.com/apache/flink-table-store/pull/372#issuecomment-1311176797
Thanks @Gerrrr for the contribution and @vvcephei for the review.
> PartialUpdateITCase.testForeignKeyJo failure seems to be flaky - I reproduced it without this patch.
I have created https://issues.apache.org/jira/browse/FLINK-29987 for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #372: [FLINK-29962] Exclude jamon 2.3.1 from dependencies
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #372:
URL: https://github.com/apache/flink-table-store/pull/372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] vvcephei commented on a diff in pull request #372: [FLINK-29962] Exclude jamon 2.3.1 from dependencies
Posted by GitBox <gi...@apache.org>.
vvcephei commented on code in PR #372:
URL: https://github.com/apache/flink-table-store/pull/372#discussion_r1019206173
##########
flink-table-store-hive/flink-table-store-hive-connector/pom.xml:
##########
@@ -266,6 +266,13 @@ under the License.
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.jamon</groupId>
+ <artifactId>jamon-runtime</artifactId>
+ <version>2.4.1</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
same here
##########
flink-table-store-hive/flink-table-store-hive-catalog/pom.xml:
##########
@@ -86,6 +86,12 @@ under the License.
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.jamon</groupId>
+ <artifactId>jamon-runtime</artifactId>
+ <version>2.4.1</version>
+ </dependency>
+
Review Comment:
I figured out in the other PR that we don't actually need to pin. Can you try without pinning (just the exclusions)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] Gerrrr commented on pull request #372: [FLINK-29962] Exclude jamon 2.3.1 from dependencies
Posted by GitBox <gi...@apache.org>.
Gerrrr commented on PR #372:
URL: https://github.com/apache/flink-table-store/pull/372#issuecomment-1310541736
`PartialUpdateITCase.testForeignKeyJo` failure seems to be flaky - I reproduced it without this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org