You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Geoffrey Jacoby (Jira)" <ji...@apache.org> on 2020/08/26 17:38:00 UTC

[jira] [Commented] (PHOENIX-6105) Run precommit tests with HBase 2.2 on master

    [ https://issues.apache.org/jira/browse/PHOENIX-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185377#comment-17185377 ] 

Geoffrey Jacoby commented on PHOENIX-6105:
------------------------------------------

Which branch(es) to run on precommit is a tricky problem. After PHOENIX-5881 there are already several tests that check for CompatBaseScannerRegionObserver.isMaxLookbackSupported() and no-op if it's false, so to run the "full" test suite you need to run 2.3. Other tests do the same check and make changes to their logic or expected assertion values based on the results. As I port the rest of the 4.x indexing JIRAs over, there will be more of these. 

So in order to get "full" validation, you'd have to run under both 2.3, and one of 2.1 or 2.2. But that would probably be prohibitively time-consuming. 

> Run precommit tests with HBase 2.2 on master
> --------------------------------------------
>
>                 Key: PHOENIX-6105
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6105
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> Since we have flakey tests that only fail with HBase 2.1, and HBase 2.3 (different sets), set up the Precommit test job to run with HBase 2.2, as that minimizes the number of false positive test failures on the precommit job.
> The afromentioned flakey tests are probably the results of HBase bugs, though this warrants further investigation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)