You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jason Gerlowski (JIRA)" <ji...@apache.org> on 2017/07/04 12:16:00 UTC

[jira] [Created] (SOLR-11004) Consolidate SolrClient Builder code in abstract parent class

Jason Gerlowski created SOLR-11004:
--------------------------------------

             Summary: Consolidate SolrClient Builder code in abstract parent class
                 Key: SOLR-11004
                 URL: https://issues.apache.org/jira/browse/SOLR-11004
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
          Components: SolrJ
    Affects Versions: master (8.0)
            Reporter: Jason Gerlowski
            Priority: Minor
             Fix For: master (8.0)


As [~anshumg] pointed out in SOLR-10456, the Builder code for each SolrClient has a lot of duplication in it.

For example, each SolrClient allows configuration of the connection timeout: all 4 builders have a field to store this value, all 4 builders have a {{withConnectionTimeout}} method to set this value, and all 4 builders have very similar Javadocs documenting what this value can be used for.

The same can be said for 5 or 6 other properties common to most/all SolrClient's.

This duplication could be removed by creating an abstract SolrClientBuilder class, which each of the specific Builders extend.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org