[GitHub] [datasketches-cpp] AlexanderSaydakov commented on a change in pull request #183: support allocator instance

[GitBox <gi...@apache.org>]

AlexanderSaydakov commented on a change in pull request #183:
URL: https://github.com/apache/datasketches-cpp/pull/183#discussion_r564146654



##########
File path: cpc/include/cpc_sketch_impl.hpp
##########
@@ -401,7 +406,7 @@ string<A> cpc_sketch_alloc<A>::to_string() const {
 
 template<typename A>
 void cpc_sketch_alloc<A>::serialize(std::ostream& os) const {
-  compressed_state<A> compressed;
+  compressed_state<A> compressed(A(sliding_window.get_allocator()));

Review comment:
       We are using a provided allocator for all allocations within an instance, including temporary allocations. I think this is good enough.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org