You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Michael Coram (JIRA)" <ji...@apache.org> on 2006/11/01 21:11:57 UTC

[jira] Created: (STR-2967) html:image takes a "module-aware" path but does not allow module to be specified

html:image takes a "module-aware" path but does not allow module to be specified
--------------------------------------------------------------------------------

                 Key: STR-2967
                 URL: http://issues.apache.org/struts/browse/STR-2967
             Project: Struts 1
          Issue Type: Bug
          Components: Taglibs
    Affects Versions: 1.3.5
            Reporter: Michael Coram
            Priority: Minor


I am using Struts modules, but I have images that span modules placed at the root of my web application.   I am attempting to use the <html:image> tag to render a <input type="image"> entry.  Unfortunately, while the Taglib docs says that page is "The module-relative path of the image for this input tag" the tag does not actually accept the module attribute.  So, you've either got to use src and specify the entire path or use a relative path.  Or, you can just fix the tag... :)

I've actually done the latter, basing the code off of what <html:img> does.   I was hoping to be able to attach it here, but not sure how...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Resolved: (STR-2967) html:image takes a "module-aware" path but does not allow module to be specified

Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/STR-2967?page=all ]

Niall Pemberton resolved STR-2967.
----------------------------------

    Fix Version/s: 1.3.6
       Resolution: Fixed
         Assignee: Niall Pemberton

Fixed in revision #470163, thanks for the patch!

I added the new module attribute to the nested and el taglibs - as well as the vanilla flavour.

http://svn.apache.org/viewvc?view=rev&revision=470163

> html:image takes a "module-aware" path but does not allow module to be specified
> --------------------------------------------------------------------------------
>
>                 Key: STR-2967
>                 URL: http://issues.apache.org/struts/browse/STR-2967
>             Project: Struts 1
>          Issue Type: Bug
>          Components: Taglibs
>    Affects Versions: 1.3.5
>            Reporter: Michael Coram
>         Assigned To: Niall Pemberton
>            Priority: Minor
>             Fix For: 1.3.6
>
>         Attachments: ImageTag.java
>
>
> I am using Struts modules, but I have images that span modules placed at the root of my web application.   I am attempting to use the <html:image> tag to render a <input type="image"> entry.  Unfortunately, while the Taglib docs says that page is "The module-relative path of the image for this input tag" the tag does not actually accept the module attribute.  So, you've either got to use src and specify the entire path or use a relative path.  Or, you can just fix the tag... :)
> I've actually done the latter, basing the code off of what <html:img> does.   I was hoping to be able to attach it here, but not sure how...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (STR-2967) html:image takes a "module-aware" path but does not allow module to be specified

Posted by "Michael Coram (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/STR-2967?page=all ]

Michael Coram updated STR-2967:
-------------------------------

    Attachment: ImageTag.java

my diffs are marked with //being module fix and //end module fix.  Also, struts-html.tld needs to be updated to add the module attribute into it:
<attribute>
<name>module</name>
<required>false</required>
<rtexprvalue>true</rtexprvalue>
</attribute>


> html:image takes a "module-aware" path but does not allow module to be specified
> --------------------------------------------------------------------------------
>
>                 Key: STR-2967
>                 URL: http://issues.apache.org/struts/browse/STR-2967
>             Project: Struts 1
>          Issue Type: Bug
>          Components: Taglibs
>    Affects Versions: 1.3.5
>            Reporter: Michael Coram
>            Priority: Minor
>         Attachments: ImageTag.java
>
>
> I am using Struts modules, but I have images that span modules placed at the root of my web application.   I am attempting to use the <html:image> tag to render a <input type="image"> entry.  Unfortunately, while the Taglib docs says that page is "The module-relative path of the image for this input tag" the tag does not actually accept the module attribute.  So, you've either got to use src and specify the entire path or use a relative path.  Or, you can just fix the tag... :)
> I've actually done the latter, basing the code off of what <html:img> does.   I was hoping to be able to attach it here, but not sure how...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira