You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2015/09/08 18:45:47 UTC
[jira] [Updated] (LUCENE-6786) Remove
IndexFileDeleter.refresh(String)
[ https://issues.apache.org/jira/browse/LUCENE-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-6786:
---------------------------------------
Attachment: LUCENE-6786.patch
Simple patch, removing the per-segment refresh and keeping the "global" refresh.
I'll beast for a while...
> Remove IndexFileDeleter.refresh(String)
> ---------------------------------------
>
> Key: LUCENE-6786
> URL: https://issues.apache.org/jira/browse/LUCENE-6786
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: Trunk, 5.4
>
> Attachments: LUCENE-6786.patch
>
>
> Today IW has try/finally around places (flush, merge) that write
> per-segment files and on exception uses IFD.refresh(String) to remove
> any newly created but now unreferenced files.
> But, since merge exceptions are now tragic, and IFD.refresh() (not
> taking a segment name) will be called, doing the same thing, I think
> it's safe to remove the per-segment refresh.
> This makes IW a little bit simpler ... and it means at least one fewer {{Directory.listAll}} while handling merge exceptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org