You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by cx...@apache.org on 2017/03/07 07:55:50 UTC
[4/8] incubator-weex git commit: * [ios] remove unused exception
handler
* [ios] remove unused exception handler
Project: http://git-wip-us.apache.org/repos/asf/incubator-weex/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-weex/commit/f92b6d64
Tree: http://git-wip-us.apache.org/repos/asf/incubator-weex/tree/f92b6d64
Diff: http://git-wip-us.apache.org/repos/asf/incubator-weex/diff/f92b6d64
Branch: refs/heads/0.11-dev
Commit: f92b6d64f223a1863d7c6b905c9bd6641a006895
Parents: 95873da
Author: \u9690\u98ce <cx...@apache.org>
Authored: Tue Mar 7 14:18:54 2017 +0800
Committer: \u9690\u98ce <cx...@apache.org>
Committed: Tue Mar 7 14:18:54 2017 +0800
----------------------------------------------------------------------
.../WeexSDK/Sources/Component/Recycler/WXRecyclerComponent.m | 5 -----
.../Sources/Component/Recycler/WXRecyclerUpdateController.h | 2 --
.../Sources/Component/Recycler/WXRecyclerUpdateController.m | 7 +------
3 files changed, 1 insertion(+), 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/f92b6d64/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerComponent.m
----------------------------------------------------------------------
diff --git a/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerComponent.m b/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerComponent.m
index d78cd57..c2eaa5d 100644
--- a/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerComponent.m
+++ b/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerComponent.m
@@ -273,11 +273,6 @@ typedef enum : NSUInteger {
}
-- (void)updateController:(WXRecyclerUpdateController *)controller willCrashWithException:(NSException *)exception oldData:(NSArray<WXSectionDataController *> *)oldData newData:(NSArray<WXSectionDataController *> *)newData
-{
- WXLogError(@"recycler update did occur an exception:%@, oldData:%@, newData:%@", exception, oldData, newData);
-}
-
#pragma mark - UICollectionViewDataSource
- (NSInteger)numberOfSectionsInCollectionView:(UICollectionView *)collectionView
http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/f92b6d64/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerUpdateController.h
----------------------------------------------------------------------
diff --git a/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerUpdateController.h b/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerUpdateController.h
index 41e6e08..e376c19 100644
--- a/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerUpdateController.h
+++ b/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerUpdateController.h
@@ -16,8 +16,6 @@
- (void)updateController:(WXRecyclerUpdateController *)controller didPerformUpdateWithFinished:(BOOL)finished;
-- (void)updateController:(WXRecyclerUpdateController *)controller willCrashWithException:(NSException *)exception oldData:(NSArray<WXSectionDataController *> *)oldData newData:(NSArray<WXSectionDataController *> *)newData;
-
@end
@interface WXRecyclerUpdateController : NSObject
http://git-wip-us.apache.org/repos/asf/incubator-weex/blob/f92b6d64/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerUpdateController.m
----------------------------------------------------------------------
diff --git a/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerUpdateController.m b/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerUpdateController.m
index 98d9ec5..87094d9 100644
--- a/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerUpdateController.m
+++ b/ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerUpdateController.m
@@ -153,12 +153,7 @@
}
WXLogDebug(@"Diff result:%@", diffResult);
- @try {
- [collectionView performBatchUpdates:updates completion:completion];
- } @catch (NSException *exception) {
- [self.delegate updateController:self willCrashWithException:exception oldData:oldData newData:newData];
- @throw exception;
- }
+ [collectionView performBatchUpdates:updates completion:completion];
}
- (void)cleanup