You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/01/09 02:24:39 UTC
[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12191
Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs
......................................................................
IMPALA-8060: [DOCS] Restructured the admission control docs
- Created a new doc category called "Resource Management".
- Moved impala_admission under Resource Management.
- Move the config steps out of impala_admission.xml and
- created impala_admission_config.xml
Change-Id: Id42ae256b215fb267023197c5052f36bedb052a3
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/topics/impala_admission.xml
A docs/topics/impala_admission_config.xml
M docs/topics/impala_resource_management.xml
5 files changed, 570 insertions(+), 740 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/12191/1
--
To view, visit http://gerrit.cloudera.org:8080/12191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id42ae256b215fb267023197c5052f36bedb052a3
Gerrit-Change-Number: 12191
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12191 )
Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12191/1/docs/topics/impala_admission.xml
File docs/topics/impala_admission.xml:
http://gerrit.cloudera.org:8080/#/c/12191/1/docs/topics/impala_admission.xml@35
PS1, Line 35: and out-of-memory conditions on busy CDH clusters. The admission control
> We should remove references to CDH
Done
--
To view, visit http://gerrit.cloudera.org:8080/12191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42ae256b215fb267023197c5052f36bedb052a3
Gerrit-Change-Number: 12191
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 19:16:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12191 )
Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/181/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42ae256b215fb267023197c5052f36bedb052a3
Gerrit-Change-Number: 12191
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 02:30:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12191 )
Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/182/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/12191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42ae256b215fb267023197c5052f36bedb052a3
Gerrit-Change-Number: 12191
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 19:44:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12191 )
Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/181/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42ae256b215fb267023197c5052f36bedb052a3
Gerrit-Change-Number: 12191
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 02:24:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12191 )
Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/182/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/12191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42ae256b215fb267023197c5052f36bedb052a3
Gerrit-Change-Number: 12191
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 19:15:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12191 )
Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs
......................................................................
Patch Set 1:
(1 comment)
LGTM except for the "CDH"s
http://gerrit.cloudera.org:8080/#/c/12191/1/docs/topics/impala_admission.xml
File docs/topics/impala_admission.xml:
http://gerrit.cloudera.org:8080/#/c/12191/1/docs/topics/impala_admission.xml@35
PS1, Line 35: and out-of-memory conditions on busy CDH clusters. The admission control
We should remove references to CDH
--
To view, visit http://gerrit.cloudera.org:8080/12191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42ae256b215fb267023197c5052f36bedb052a3
Gerrit-Change-Number: 12191
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 18:35:08 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12191
to look at the new patch set (#2).
Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs
......................................................................
IMPALA-8060: [DOCS] Restructured the admission control docs
- Created a new doc category called "Resource Management".
- Moved impala_admission under Resource Management.
- Move the config steps out of impala_admission.xml and
- created impala_admission_config.xml
Change-Id: Id42ae256b215fb267023197c5052f36bedb052a3
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/topics/impala_admission.xml
A docs/topics/impala_admission_config.xml
M docs/topics/impala_dedicated_coordinator.xml
M docs/topics/impala_resource_management.xml
6 files changed, 573 insertions(+), 745 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/12191/2
--
To view, visit http://gerrit.cloudera.org:8080/12191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id42ae256b215fb267023197c5052f36bedb052a3
Gerrit-Change-Number: 12191
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12191 )
Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs
......................................................................
IMPALA-8060: [DOCS] Restructured the admission control docs
- Created a new doc category called "Resource Management".
- Moved impala_admission under Resource Management.
- Move the config steps out of impala_admission.xml and
- created impala_admission_config.xml
Change-Id: Id42ae256b215fb267023197c5052f36bedb052a3
Reviewed-on: http://gerrit.cloudera.org:8080/12191
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/topics/impala_admission.xml
A docs/topics/impala_admission_config.xml
M docs/topics/impala_dedicated_coordinator.xml
M docs/topics/impala_resource_management.xml
6 files changed, 573 insertions(+), 745 deletions(-)
Approvals:
Bikramjeet Vig: Looks good to me, but someone else must approve
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id42ae256b215fb267023197c5052f36bedb052a3
Gerrit-Change-Number: 12191
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12191 )
Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42ae256b215fb267023197c5052f36bedb052a3
Gerrit-Change-Number: 12191
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 20:01:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8060: [DOCS] Restructured the admission control docs
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12191 )
Change subject: IMPALA-8060: [DOCS] Restructured the admission control docs
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12191/2/docs/topics/impala_admission.xml
File docs/topics/impala_admission.xml:
http://gerrit.cloudera.org:8080/#/c/12191/2/docs/topics/impala_admission.xml@122
PS2, Line 122: It
nit: in
--
To view, visit http://gerrit.cloudera.org:8080/12191
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42ae256b215fb267023197c5052f36bedb052a3
Gerrit-Change-Number: 12191
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jan 2019 19:32:14 +0000
Gerrit-HasComments: Yes