You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/02/05 13:01:22 UTC

[GitHub] flink pull request #5412: [FLINK-8559][RocksDB] Release resources if snapsho...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5412

    [FLINK-8559][RocksDB] Release resources if snapshot operation fails

    ## What is the purpose of the change
    
    This PR ensures that RocksDB resources are released if `RocksDBIncrementalSnapshotOperation#takeSnapshot` throws an Exception.
    
    We now catch the exception, cancel the SnapshotOperation, and re-throw the original exception.
    
    ## Verifying this change
    
    I've verified this manually by running `JobManagerHACheckpointRecoveryITCase` on Windows where `takeSnapshot` fails due to FLINK-8557.
    
    I couldn't come up with proper test. The method hardly does anything in the first place and every solution i could think of would depend a lot on implementation details (like mocking `Checkpoint.create()` to throw an exception).
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    
    @StefanRRichter 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8559

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5412.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5412
    
----
commit 05f0ff5e353117894af4ba7dc096c3256d80450b
Author: zentol <ch...@...>
Date:   2018-02-05T12:15:29Z

    [FLINK-8559][RocksDB] Release resources if snapshot operation fails

----


---

[GitHub] flink pull request #5412: [FLINK-8559][RocksDB] Release resources if snapsho...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5412


---

[GitHub] flink issue #5412: [FLINK-8559][RocksDB] Release resources if snapshot opera...

Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/5412
  
    LGTM


---

[GitHub] flink issue #5412: [FLINK-8559][RocksDB] Release resources if snapshot opera...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5412
  
    merging.


---