You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@jspwiki.apache.org by Juan Pablo Santos Rodríguez <ju...@gmail.com> on 2015/07/08 01:11:19 UTC
Re: JSPWiki build failure
Hi David, Dave,
made a bunch of small tweaks to prepare for the 2.10.2 release, both of
your issues should be fixed on latest svn trunk. Would you mind trying to
build without su access? Also the numbers issue shuold be fixed too, I
think it was related to how JSPWIKI-821 was fixed.
thanks!
On Tue, Jun 23, 2015 at 1:32 PM, David Vittor <dv...@gmail.com> wrote:
> Ah sorry - I got confused here. Yes the code accidentally came in with
> 2.10.2-svn-18.However I've reverted this code back, as this is a much
> larger change, that I will put on a branch.
>
> As for this immediate problem. I agree. It should use the "target"
> directory, and it should only remove the "digits" from the autogenerated
> part.
>
> I'll look at making this change soon.
>
> Cheers,
> David V
>
>
> On Tue, Jun 23, 2015 at 9:12 PM, David Vittor <dv...@gmail.com> wrote:
>
> > That's a good idea Juan, I'll revert my code from the trunk and create a
> > new branch for this change.
> >
> > Cheers,
> > David V
> >
> >
> > On Tue, Jun 23, 2015 at 9:06 PM, Juan Pablo Santos Rodríguez <
> > juanpablo.santos@gmail.com> wrote:
> >
> >> Hi David,
> >>
> >> skimming through the 2.10.1-svn-18 commit, it seems it has entered on
> >> trunk. I recall that code being necessary so some test didn't create
> >> duplicate folders, but I'd rather check the svn history of that file to
> >> see
> >> where & why that replace was made. In any case, it should generate a
> >> folder
> >> inside target not in user.home or java.io.tmpdir, and should remove the
> >> digits only the autogenerated part of the path (not the
> >> user.home/java.io.tmpdir)
> >>
> >>
> >> br,
> >> juan pablo
> >>
> >> On Tue, Jun 23, 2015 at 10:48 AM, David Vittor <dv...@gmail.com>
> wrote:
> >>
> >> > Funny that I had the same problem yesterday.
> >> >
> >> > I was trying to build the code on another laptop where my username was
> >> > C:/Users/david4 and the code kept removing the "4" after my name.
> >> >
> >> > I tracked this down in the testing code TestEngine.cleanTestProps(),
> and
> >> > here are my comments - not checked in :)
> >> >
> >> > props.setProperty( AbstractFileProvider.PROP_PAGEDIR,
> >> > pageDir // TODO: Is this really required,
> why
> >> > remove digits? .replaceAll( "\\d", StringUtils.EMPTY )
> >> > + System.currentTimeMillis() );
> >> >
> >> > Let me know if you want to remove this replaceAll, and check it in.
> >> >
> >> > Cheers,
> >> > David V
> >> >
> >> >
> >> >
> >> >
> >> > On Tue, Jun 23, 2015 at 6:09 PM, Juan Pablo Santos Rodríguez <
> >> > juanpablo.santos@gmail.com> wrote:
> >> >
> >> > > Hi Dave,
> >> > >
> >> > > you should be able to run the build without any special permissions
> >> (that
> >> > > is, the files generated by the build should be under
> >> ./target/whatever),
> >> > > would you mind filing a JIRA so this doesn't get lost?
> >> > >
> >> > >
> >> > > thanks,
> >> > > juan pablo
> >> > >
> >> > > On Tue, Jun 23, 2015 at 9:58 AM, Dave Koelmeyer <
> >> > > dave.koelmeyer@davekoelmeyer.co.nz> wrote:
> >> > >
> >> > > > Hi All,
> >> > > >
> >> > > > On 23/06/15 18:32, Juan Pablo Santos Rodríguez wrote:
> >> > > > >
> >> > > > > I'll look closely into it this afternoon, but currently our CI
> >> build
> >> > is
> >> > > > > passing [#1], so it seems somehow related to the build
> >> environment?
> >> > > > >
> >> > > > > The offending test is trying to create a wiki page dir under
> >> > > > > $java.io.tmpir/non-existent-directory, which is the reason of
> the
> >> > > failing
> >> > > > > test. Dave, would you mind confirming that your user is able to
> >> > create
> >> > > > > files/folders inside that directory? In anycase, I'll switch the
> >> test
> >> > > > this
> >> > > > > afternoon so it creates the temporary folder inside ./target, in
> >> > order
> >> > > to
> >> > > > > avoid file-access permissions problems.
> >> > > >
> >> > > > My bad, running mvn pacakge as the superuser gives me a successful
> >> > build
> >> > > > (sorry, I should have tried this before posting). Curiously,
> >> assuming
> >> > my
> >> > > > login account is a non-root user, and is called "dkoe123", a new
> >> > > > directory is created as a byproduct of running sudo mvn package,
> >> called
> >> > > > "dkoe", and located at /home. Several directories deep, it
> contains
> >> > > > these folders (and is otherwise empty):
> >> > > >
> >> > > > /home/dkoe/Desktop/jspwiki/jspwiki-war/target
> >> > > >
> >> > > > Anyway thanks for the pointer :)
> >> > > >
> >> > > > Cheers,
> >> > > > Dave
> >> > > >
> >> > > >
> >> > > >
> >> > > > > juan pablo
> >> > > > >
> >> > > > >
> >> > > > > [#1]: https://builds.apache.org/job/JSPWiki/
> >> > > > >
> >> > > > > On Tue, Jun 23, 2015 at 8:11 AM, Florian Holeczek <
> >> > florian@holeczek.de
> >> > > >
> >> > > > > wrote:
> >> > > > >
> >> > > > >> Hi Dave and Juan Pablo,
> >> > > > >>
> >> > > > >>> I'm attempting to build JSPWiki from source at the moment and
> >> Maven
> >> > > is
> >> > > > >>> failing with this error:
> >> > > > >>
> >> > > > >> seems to have been introduced with Juan Pablo's little commit:
> >> > > > >>
> >> > > > >> URL: http://svn.apache.org/r1684742
> >> > > > >> Log:
> >> > > > >> change sample keys so they match with the ones at at
> >> > > > >> org.apache.wiki.attachment.AttachmentManager
> >> > > > >>
> >> > > > >> I didn't have a look at the details though, just confirming.
> >> > > > >>
> >> > > > >> Regards
> >> > > > >> Florian
> >> > > >
> >> > > >
> >> > >
> >> >
> >>
> >
> >
>
Re: JSPWiki build failure
Posted by Dave Koelmeyer <da...@davekoelmeyer.co.nz>.
On 08/07/15 22:36, Dave Koelmeyer wrote:
> On 08/07/15 11:11, Juan Pablo Santos Rodríguez wrote:
>> Hi David, Dave,
>>
>> made a bunch of small tweaks to prepare for the 2.10.2 release, both of
>> your issues should be fixed on latest svn trunk. Would you mind trying to
>> build without su access? Also the numbers issue shuold be fixed too, I
>> think it was related to how JSPWIKI-821 was fixed.
>
> Hi Juan Pablo,
>
> Looks good here, and I can build with sudo required – thanks! :)
Argh, I mean of course I can build *without* sudo required.
Cheers,
Dave
--
Dave Koelmeyer
http://blog.davekoelmeyer.co.nz
Re: JSPWiki build failure
Posted by Dave Koelmeyer <da...@davekoelmeyer.co.nz>.
On 08/07/15 11:11, Juan Pablo Santos Rodríguez wrote:
> Hi David, Dave,
>
> made a bunch of small tweaks to prepare for the 2.10.2 release, both of
> your issues should be fixed on latest svn trunk. Would you mind trying to
> build without su access? Also the numbers issue shuold be fixed too, I
> think it was related to how JSPWIKI-821 was fixed.
Hi Juan Pablo,
Looks good here, and I can build with sudo required – thanks! :)
Cheers,
Dave
--
Dave Koelmeyer
http://blog.davekoelmeyer.co.nz