You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by gi...@git.apache.org on 2017/05/26 15:58:20 UTC

[GitHub] rafaelweingartner commented on a change in pull request #2124: CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root domain

rafaelweingartner commented on a change in pull request #2124: CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root domain
URL: https://github.com/apache/cloudstack/pull/2124#discussion_r118734162
 
 

 ##########
 File path: server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java
 ##########
 @@ -323,12 +330,12 @@ public void doInTransactionWithoutResult(TransactionStatus status) {
         List<String> types = new ArrayList<String>();
 
         for (AffinityGroupProcessor processor : _affinityProcessors) {
-                if (processor.isAdminControlledGroup()) {
-                    continue; // we dont list the type if this group can be
-                              // created only as an admin/system operation.
-                }
-                types.add(processor.getType());
+            if (processor.isAdminControlledGroup()) {
 
 Review comment:
   Are these formatting changes needed?
   Are you using the CloudStack code formatter style? Or was the code not formatted properly?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services