[GitHub] [tvm] mei-ye commented on pull request #10124: [relay] Fix stack overflow in device_planner observed on windows due …

[GitBox <gi...@apache.org>]

mei-ye commented on pull request #10124:
URL: https://github.com/apache/tvm/pull/10124#issuecomment-1026504575


   > Is it possible to use the MixedModeVisitor instead of manually creating an imperative stack here? cc @mbs-octoml
   
   Thanks for the pointer to MixedModeVisitor. It appears to me that MixedModeVisitor does something like:
   foreach node in PDFS order {
      do(..)
   }
   
   The device_planner does something like:
   foreach node visited {
      do_1()
      visit_child_nodes()
      do_2()
   }
   unless we can merge do_1 into do_2, the semantics is not equivalent to MixeModeVisitor.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org