You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Pallavi Rao <pa...@inmobi.com> on 2015/09/11 09:28:07 UTC
Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1434
https://issues.apache.org/jira/browse/FALCON-1434
Repository: falcon-git
Description
-------
The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
Example:
bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
Diffs
-----
client/src/main/java/org/apache/falcon/cli/FalconCLI.java d4da302
client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 282b41b
client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2
common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java f9405dc
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java ceabb06
unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3
unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301
unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1f8cc1b
Diff: https://reviews.apache.org/r/38294/diff/
Testing
-------
UT added
Manually tested to ensure CLI accepts properties and it is propagated.
Thanks,
Pallavi Rao
Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/#review99300
-----------------------------------------------------------
Ship it!
Ship It!
- Balu Vellanki
On Sept. 16, 2015, 10:23 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38294/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 10:23 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1434
> https://issues.apache.org/jira/browse/FALCON-1434
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
> Example:
> bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java e684678
> client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 1146011
> client/src/main/java/org/apache/falcon/client/FalconClient.java 6075f5c
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java 2f05b1f
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
> common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java f6a4679
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 61638f3
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 23f1605
> unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java d907683
> unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java df73628
> unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 3bafb25
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b859256
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 220e5a7
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java f031137
>
> Diff: https://reviews.apache.org/r/38294/diff/
>
>
> Testing
> -------
>
> UT added
> Manually tested to ensure CLI accepts properties and it is propagated.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/#review99345
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/client/FalconClient.java (line 315)
<https://reviews.apache.org/r/38294/#comment156239>
This is a bad way of doing it. There are substantial differences in terms of mandatory arguments for each caller (resume/delete etc.)
Secondly this requires change in one to touch all other calls as well.
We should write an overloaded version or another function.
Please update the docs as well.
- Ajay Yadava
On Sept. 16, 2015, 10:23 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38294/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 10:23 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1434
> https://issues.apache.org/jira/browse/FALCON-1434
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
> Example:
> bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java e684678
> client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 1146011
> client/src/main/java/org/apache/falcon/client/FalconClient.java 6075f5c
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java 2f05b1f
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
> common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java f6a4679
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 61638f3
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 23f1605
> unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java d907683
> unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java df73628
> unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 3bafb25
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b859256
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 220e5a7
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java f031137
>
> Diff: https://reviews.apache.org/r/38294/diff/
>
>
> Testing
> -------
>
> UT added
> Manually tested to ensure CLI accepts properties and it is propagated.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
Posted by Sowmya Ramesh <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/#review99295
-----------------------------------------------------------
Ship it!
Ship It!
- Sowmya Ramesh
On Sept. 16, 2015, 10:23 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38294/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 10:23 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1434
> https://issues.apache.org/jira/browse/FALCON-1434
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
> Example:
> bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java e684678
> client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 1146011
> client/src/main/java/org/apache/falcon/client/FalconClient.java 6075f5c
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java 2f05b1f
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
> common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java f6a4679
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 61638f3
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 23f1605
> unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java d907683
> unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java df73628
> unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 3bafb25
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b859256
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 220e5a7
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java f031137
>
> Diff: https://reviews.apache.org/r/38294/diff/
>
>
> Testing
> -------
>
> UT added
> Manually tested to ensure CLI accepts properties and it is propagated.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/
-----------------------------------------------------------
(Updated Sept. 16, 2015, 10:23 a.m.)
Review request for Falcon.
Changes
-------
Rebased patch, with minor comment addressed.
Bugs: FALCON-1434
https://issues.apache.org/jira/browse/FALCON-1434
Repository: falcon-git
Description
-------
The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
Example:
bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/cli/FalconCLI.java e684678
client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 1146011
client/src/main/java/org/apache/falcon/client/FalconClient.java 6075f5c
common/src/main/java/org/apache/falcon/entity/EntityUtil.java 2f05b1f
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java f6a4679
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 61638f3
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 23f1605
unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java d907683
unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java df73628
unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 3bafb25
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java b859256
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java 220e5a7
webapp/src/test/java/org/apache/falcon/resource/TestContext.java f031137
Diff: https://reviews.apache.org/r/38294/diff/
Testing
-------
UT added
Manually tested to ensure CLI accepts properties and it is propagated.
Thanks,
Pallavi Rao
Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/#review98854
-----------------------------------------------------------
Ship it!
Ship It!
- Balu Vellanki
On Sept. 14, 2015, 6:21 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38294/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 6:21 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1434
> https://issues.apache.org/jira/browse/FALCON-1434
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
> Example:
> bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java d4da302
> client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 282b41b
> client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
> common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java f9405dc
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java ceabb06
> unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3
> unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301
> unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1f8cc1b
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0062070
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java bcd3bd5
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 54671fb
>
> Diff: https://reviews.apache.org/r/38294/diff/
>
>
> Testing
> -------
>
> UT added
> Manually tested to ensure CLI accepts properties and it is propagated.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/#review98992
-----------------------------------------------------------
Ship it!
Ship It!
- pavan kumar kolamuri
On Sept. 14, 2015, 6:21 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38294/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 6:21 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1434
> https://issues.apache.org/jira/browse/FALCON-1434
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
> Example:
> bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java d4da302
> client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 282b41b
> client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
> common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java f9405dc
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java ceabb06
> unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3
> unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301
> unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1f8cc1b
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0062070
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java bcd3bd5
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 54671fb
>
> Diff: https://reviews.apache.org/r/38294/diff/
>
>
> Testing
> -------
>
> UT added
> Manually tested to ensure CLI accepts properties and it is propagated.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
Posted by Pallavi Rao <pa...@inmobi.com>.
> On Sept. 16, 2015, 7:07 a.m., Sowmya Ramesh wrote:
> > common/src/main/java/org/apache/falcon/entity/EntityUtil.java, line 908
> > <https://reviews.apache.org/r/38294/diff/2/?file=1072162#file1072162line908>
> >
> > Minor nit: update the message in exception as keyvalue[0] or keyvalue[1] can be invalid
keyvalue[1] may not exist (invalid property). If I use that in the message I'll get an IndexOutOfBounds. Don't want to add additional length checks just for a message. The message anyway points out which key is invalid.
- Pallavi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/#review99191
-----------------------------------------------------------
On Sept. 14, 2015, 6:21 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38294/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 6:21 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1434
> https://issues.apache.org/jira/browse/FALCON-1434
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
> Example:
> bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java d4da302
> client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 282b41b
> client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
> common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java f9405dc
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java ceabb06
> unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3
> unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301
> unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1f8cc1b
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0062070
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java bcd3bd5
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 54671fb
>
> Diff: https://reviews.apache.org/r/38294/diff/
>
>
> Testing
> -------
>
> UT added
> Manually tested to ensure CLI accepts properties and it is propagated.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
Posted by Sowmya Ramesh <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/#review99191
-----------------------------------------------------------
common/src/main/java/org/apache/falcon/entity/EntityUtil.java (line 908)
<https://reviews.apache.org/r/38294/#comment156103>
Minor nit: update the message in exception as keyvalue[0] or keyvalue[1] can be invalid
webapp/src/test/java/org/apache/falcon/resource/TestContext.java (line 295)
<https://reviews.apache.org/r/38294/#comment156109>
Minor nit: Can you use StringUtils.isNotEmpty instead?
- Sowmya Ramesh
On Sept. 14, 2015, 6:21 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38294/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 6:21 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1434
> https://issues.apache.org/jira/browse/FALCON-1434
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
> Example:
> bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java d4da302
> client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 282b41b
> client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
> common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java f9405dc
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java ceabb06
> unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3
> unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301
> unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1f8cc1b
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0062070
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java bcd3bd5
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 54671fb
>
> Diff: https://reviews.apache.org/r/38294/diff/
>
>
> Testing
> -------
>
> UT added
> Manually tested to ensure CLI accepts properties and it is propagated.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 6:21 a.m.)
Review request for Falcon.
Changes
-------
Addressed review comments
Bugs: FALCON-1434
https://issues.apache.org/jira/browse/FALCON-1434
Repository: falcon-git
Description
-------
The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
Example:
bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/cli/FalconCLI.java d4da302
client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 282b41b
client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2
common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java f9405dc
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java ceabb06
unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3
unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301
unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1f8cc1b
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0062070
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java bcd3bd5
webapp/src/test/java/org/apache/falcon/resource/TestContext.java 54671fb
Diff: https://reviews.apache.org/r/38294/diff/
Testing
-------
UT added
Manually tested to ensure CLI accepts properties and it is propagated.
Thanks,
Pallavi Rao
Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
Posted by Pallavi Rao <pa...@inmobi.com>.
> On Sept. 11, 2015, 5:59 p.m., Sowmya Ramesh wrote:
> > common/src/main/java/org/apache/falcon/entity/EntityUtil.java, line 905
> > <https://reviews.apache.org/r/38294/diff/1/?file=1068154#file1068154line905>
> >
> > Can keyValue[0] be empty?
Nope. Addressed that.
- Pallavi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/#review98645
-----------------------------------------------------------
On Sept. 14, 2015, 6:21 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38294/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 6:21 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1434
> https://issues.apache.org/jira/browse/FALCON-1434
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
> Example:
> bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java d4da302
> client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 282b41b
> client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
> common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java f9405dc
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java ceabb06
> unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3
> unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301
> unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1f8cc1b
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0062070
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java bcd3bd5
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 54671fb
>
> Diff: https://reviews.apache.org/r/38294/diff/
>
>
> Testing
> -------
>
> UT added
> Manually tested to ensure CLI accepts properties and it is propagated.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
Posted by Sowmya Ramesh <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/#review98645
-----------------------------------------------------------
Couple of queries
1> key-value properties - Is it not required to allow this for already scheduled entities? i.e. should be allowed for update operation too
2> Does any property passed in key-value properties requires validation? Was wondering if it is required for validate.
common/src/main/java/org/apache/falcon/entity/EntityUtil.java (line 905)
<https://reviews.apache.org/r/38294/#comment155155>
Can keyValue[0] be empty?
common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java (line 338)
<https://reviews.apache.org/r/38294/#comment155157>
You can move invalid prop test to new test and use @Test expectedExceptions and expectedExceptionsMessageRegExp - much cleaner way.
- Sowmya Ramesh
On Sept. 11, 2015, 7:28 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38294/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 7:28 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1434
> https://issues.apache.org/jira/browse/FALCON-1434
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
> Example:
> bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java d4da302
> client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 282b41b
> client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
> common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java f9405dc
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java ceabb06
> unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3
> unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301
> unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1f8cc1b
>
> Diff: https://reviews.apache.org/r/38294/diff/
>
>
> Testing
> -------
>
> UT added
> Manually tested to ensure CLI accepts properties and it is propagated.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
Posted by Pallavi Rao <pa...@inmobi.com>.
> On Sept. 11, 2015, 6:12 p.m., pavan kumar kolamuri wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 439
> > <https://reviews.apache.org/r/38294/diff/1/?file=1068151#file1068151line439>
> >
> > Instead of taking props as String, won't it be good to take props from a file ? Like for instance rerun we are taking props from file.
These are properties meant for scheduler. Don't expect it to be too many. In fact, right now, I just have one in mind :-). If this list grows, then we can consider supporting a properties file.
- Pallavi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/#review98652
-----------------------------------------------------------
On Sept. 14, 2015, 6:21 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38294/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 6:21 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1434
> https://issues.apache.org/jira/browse/FALCON-1434
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
> Example:
> bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java d4da302
> client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 282b41b
> client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
> common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java f9405dc
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java ceabb06
> unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3
> unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301
> unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1f8cc1b
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0062070
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java bcd3bd5
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 54671fb
>
> Diff: https://reviews.apache.org/r/38294/diff/
>
>
> Testing
> -------
>
> UT added
> Manually tested to ensure CLI accepts properties and it is propagated.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/#review98652
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 439)
<https://reviews.apache.org/r/38294/#comment155160>
Instead of taking props as String, won't it be good to take props from a file ? Like for instance rerun we are taking props from file.
- pavan kumar kolamuri
On Sept. 11, 2015, 7:28 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38294/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 7:28 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1434
> https://issues.apache.org/jira/browse/FALCON-1434
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
> Example:
> bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java d4da302
> client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 282b41b
> client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
> common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java f9405dc
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java ceabb06
> unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3
> unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301
> unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1f8cc1b
>
> Diff: https://reviews.apache.org/r/38294/diff/
>
>
> Testing
> -------
>
> UT added
> Manually tested to ensure CLI accepts properties and it is propagated.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
Posted by Pallavi Rao <pa...@inmobi.com>.
> On Sept. 11, 2015, 3:28 p.m., Balu Vellanki wrote:
> > common/src/main/java/org/apache/falcon/entity/EntityUtil.java, line 904
> > <https://reviews.apache.org/r/38294/diff/1/?file=1068154#file1068154line904>
> >
> > Do you not allow ":" character in the value? I see value in allowing ":" in the value for properties. Splitting kvPair into two Strings might be more helpful.
> >
> > String[] keyValue = kvPair.trim().split(":", 2);
Makes sense. Will allow : in values.
> On Sept. 11, 2015, 3:28 p.m., Balu Vellanki wrote:
> > common/src/main/java/org/apache/falcon/entity/EntityUtil.java, line 905
> > <https://reviews.apache.org/r/38294/diff/1/?file=1068154#file1068154line905>
> >
> > This can allow the keyValue[0] to be empty. I think we should not have empty property keys.
Good catch. Added an additional check.
> On Sept. 11, 2015, 3:28 p.m., Balu Vellanki wrote:
> > common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java, line 337
> > <https://reviews.apache.org/r/38294/diff/1/?file=1068156#file1068156line337>
> >
> > Please add " :value1" to list of invalid props.
Done.
> On Sept. 11, 2015, 3:28 p.m., Balu Vellanki wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 94
> > <https://reviews.apache.org/r/38294/diff/1/?file=1068151#file1068151line94>
> >
> > Minor nit - Can we use "properties" instead?
> >
> > Can we also add some tests to EntityManagerJerseyIT?
Changed to "properties".
Just enhanced the existing tests in FalconCLIIT and EntityManagerJerseyIT. Didn't add any new test as the properties aren't really used yet.
- Pallavi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/#review98613
-----------------------------------------------------------
On Sept. 14, 2015, 6:21 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38294/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 6:21 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1434
> https://issues.apache.org/jira/browse/FALCON-1434
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
> Example:
> bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java d4da302
> client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 282b41b
> client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
> common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java f9405dc
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java ceabb06
> unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3
> unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301
> unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1f8cc1b
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 0062070
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java bcd3bd5
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 54671fb
>
> Diff: https://reviews.apache.org/r/38294/diff/
>
>
> Testing
> -------
>
> UT added
> Manually tested to ensure CLI accepts properties and it is propagated.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 38294: FALCON-1434 Enhance schedule API to accept
key-value properties
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38294/#review98613
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 94)
<https://reviews.apache.org/r/38294/#comment155140>
Minor nit - Can we use "properties" instead?
Can we also add some tests to EntityManagerJerseyIT?
common/src/main/java/org/apache/falcon/entity/EntityUtil.java (line 904)
<https://reviews.apache.org/r/38294/#comment155137>
Do you not allow ":" character in the value? I see value in allowing ":" in the value for properties. Splitting kvPair into two Strings might be more helpful.
String[] keyValue = kvPair.trim().split(":", 2);
common/src/main/java/org/apache/falcon/entity/EntityUtil.java (line 905)
<https://reviews.apache.org/r/38294/#comment155138>
This can allow the keyValue[0] to be empty. I think we should not have empty property keys.
common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java (line 337)
<https://reviews.apache.org/r/38294/#comment155139>
Please add " :value1" to list of invalid props.
- Balu Vellanki
On Sept. 11, 2015, 7:28 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38294/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2015, 7:28 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1434
> https://issues.apache.org/jira/browse/FALCON-1434
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The schedule API will be enhanced to accept a key-value properties. This is a foundation to enable users to specify the scheduler on which they want to schedule the entity. This in turn enables migration to native scheduler from Oozie.
> Example:
> bin/falcon entity -schedule -props falcon.scheduler=native -name <entity name>
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java d4da302
> client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 282b41b
> client/src/main/java/org/apache/falcon/client/FalconClient.java 44436d2
> common/src/main/java/org/apache/falcon/entity/EntityUtil.java 25d9008
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java ea86c2a
> common/src/test/java/org/apache/falcon/entity/EntityUtilTest.java cfdc84d
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 5f79ca1
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java f9405dc
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java ceabb06
> unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java eb65cb3
> unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 997b301
> unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java 498f50e
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1f8cc1b
>
> Diff: https://reviews.apache.org/r/38294/diff/
>
>
> Testing
> -------
>
> UT added
> Manually tested to ensure CLI accepts properties and it is propagated.
>
>
> Thanks,
>
> Pallavi Rao
>
>