You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/10 12:06:57 UTC
[GitHub] [superset] zhouyao1994 opened a new pull request, #21037: docs: Format the same size of picture for better part of "Supported Databases" document
zhouyao1994 opened a new pull request, #21037:
URL: https://github.com/apache/superset/pull/21037
https://github.com/apache/superset/issues/21028#issue-1333247890
No code change
type:png size:400*160
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
[before]
[after]
<img width="972" alt="image" src="https://user-images.githubusercontent.com/5468589/183896804-b3d55e73-c871-4c8c-bd8f-64d24b3be1f9.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhouyao1994 commented on pull request #21037: docs: Format the same size of picture for better part of "Supported Databases" document
Posted by GitBox <gi...@apache.org>.
zhouyao1994 commented on PR #21037:
URL: https://github.com/apache/superset/pull/21037#issuecomment-1210599603
@zhaoyongjie May be can hlep me review this 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify commented on pull request #21037: docs: Format the same size of picture for better part of "Supported Databases" document
Posted by GitBox <gi...@apache.org>.
srinify commented on PR #21037:
URL: https://github.com/apache/superset/pull/21037#issuecomment-1222820709
Love it, thanks for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21037: docs: Format the same size of picture for better part of "Supported Databases" document
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21037:
URL: https://github.com/apache/superset/pull/21037#issuecomment-1210634833
# [Codecov](https://codecov.io/gh/apache/superset/pull/21037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21037](https://codecov.io/gh/apache/superset/pull/21037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d1d6b7) into [master](https://codecov.io/gh/apache/superset/commit/dfe5a0493886136620ec3046d315b8d1159503d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfe5a04) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 6d1d6b7 differs from pull request most recent head 837c798. Consider uploading reports for the commit 837c798 to get more accurate results
```diff
@@ Coverage Diff @@
## master #21037 +/- ##
=======================================
Coverage 66.26% 66.26%
=======================================
Files 1769 1769
Lines 67470 67470
Branches 7170 7170
=======================================
Hits 44708 44708
Misses 20931 20931
Partials 1831 1831
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.01% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify merged pull request #21037: docs: Format the same size of picture for better part of "Supported Databases" document
Posted by GitBox <gi...@apache.org>.
srinify merged PR #21037:
URL: https://github.com/apache/superset/pull/21037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org