You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/05 08:49:35 UTC
[GitHub] [spark] LuciferYang commented on a diff in pull request #39406: [SPARK-41894][SS][TESTS] Add new action to `testAsyncWriteErrorsPermissionsIssue` to restore the write permission of `commitDir`.
LuciferYang commented on code in PR #39406:
URL: https://github.com/apache/spark/pull/39406#discussion_r1062234922
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/AsyncProgressTrackingMicroBatchExecutionSuite.scala:
##########
@@ -750,6 +750,12 @@ class AsyncProgressTrackingMicroBatchExecutionSuite
}
e.getCause.getCause.getMessage should include("Permission denied")
}
+ },
+ Execute { _ =>
+ // SPARK-41894: Restore the write permission of `commitDir`
+ // so that `mvn clean` can run successfully.
+ val commitDir = new File(checkpointLocation + path)
+ commitDir.setWritable(true)
Review Comment:
https://github.com/apache/spark/blob/58d5dc3d573dfbb6d21ea41d101550146756f45b/sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/AsyncProgressTrackingMicroBatchExecutionSuite.scala#L736-L743
Line 741 `commitDir.setReadOnly()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org