You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "rich7420 (via GitHub)" <gi...@apache.org> on 2026/10/17 06:33:00 UTC
[PR] HDDS-16661. Validate unsigned S3 checksum trailer completion and framing [ozone]
rich7420 opened a new pull request, #11586:
URL: https://github.com/apache/ozone/pull/11586
## What changes were proposed in this pull request?
Unsigned chunked uploads stop after the decoded payload, so a missing or malformed checksum trailer can be accepted. Parse the declared trailer and require valid framing, Base64, checksum length, and end of body before committing an object or multipart part. Apply completion checks to the FSO directory path as well.
Reuse the typed trailer declaration and the existing write guard. Payload checksum comparison is handled separately in HDDS-16660.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16661
## How was this patch tested?
- Final targeted local suites: 269 tests, no failures or errors; checkstyle passed.
- New endpoint and FSO regressions fail without the fix, including missing/truncated trailers and invalid decoded length.
- [Fork CI](https://github.com/rich7420/ozone/actions/runs/38928401714): passed at `ca00873f1f`.
- [10×10 on the same commit](https://github.com/rich7420/ozone/actions/runs/38939656367): passed for `TestUnsignedChunkInputStream`, `TestObjectPut`, `TestPartUpload`, and `TestS3ObjectWriteGuard`.
Generated-by: Codex (GPT-6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16661. Validate unsigned S3 checksum trailer completion and framing [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11586:
URL: https://github.com/apache/ozone/pull/11586#issuecomment-6394187246
@chungen0126 would you like to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16661. Validate unsigned S3 checksum trailer completion and framing [ozone]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #11586:
URL: https://github.com/apache/ozone/pull/11586#issuecomment-6333709500
Flaky test `TestFinalizeBlock` is unrelated, tracked in [HDDS-17213](https://issues.apache.org/jira/browse/HDDS-17213). Passed in [fork CI](https://github.com/rich7420/ozone/actions/runs/39642974149).
```
[ERROR] org.apache.hadoop.ozone.container.common.statemachine.commandhandler.TestFinalizeBlock.testFinalizeBlock(boolean)[1] -- Time elapsed: 28.08 s <<< ERROR!
java.io.IOException: INTERNAL_ERROR org.apache.hadoop.ozone.om.exceptions.OMException: Unable to allocate a container to the block of size: 4194304, replicationConfig: RATIS/ONE. Pipeline 6c4a02ea-4214-4aae-b5b7-f0a8f6a7c43d is not ready in 1000 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16661. Validate unsigned S3 checksum trailer completion and framing [ozone]
Posted by "chungen0126 (via GitHub)" <gi...@apache.org>.
chungen0126 commented on PR #11586:
URL: https://github.com/apache/ozone/pull/11586#issuecomment-6413073117
Merged. Thanks @rich7420 for working on this, @adoroszlai @chihsuan for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16661. Validate unsigned S3 checksum trailer completion and framing [ozone]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #11586:
URL: https://github.com/apache/ozone/pull/11586#issuecomment-6249651845
@adoroszlai got it! thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16661. Validate unsigned S3 checksum trailer completion and framing [ozone]
Posted by "chungen0126 (via GitHub)" <gi...@apache.org>.
chungen0126 commented on PR #11586:
URL: https://github.com/apache/ozone/pull/11586#issuecomment-6394268920
Hi @adoroszlai , sorry for the delay. I'll review this as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16661. Validate unsigned S3 checksum trailer completion and framing [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11586:
URL: https://github.com/apache/ozone/pull/11586#issuecomment-6249489983
Converted to draft only to "stack" CI runs: resolving conflicts will first trigger CI only in fork, then after successful run it can be marked "ready for review".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16661. Validate unsigned S3 checksum trailer completion and framing [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11586:
URL: https://github.com/apache/ozone/pull/11586#issuecomment-6383934664
Thanks for the patch. I would like to defer merging this after #11735, which will (hopefully) allow skipping most integration tests for S3-only changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16661. Validate unsigned S3 checksum trailer completion and framing [ozone]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #11586:
URL: https://github.com/apache/ozone/pull/11586#issuecomment-6384863140
@adoroszlai no problem, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16661. Validate unsigned S3 checksum trailer completion and framing [ozone]
Posted by "chungen0126 (via GitHub)" <gi...@apache.org>.
chungen0126 merged PR #11586:
URL: https://github.com/apache/ozone/pull/11586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16661. Validate unsigned S3 checksum trailer completion and framing [ozone]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #11586:
URL: https://github.com/apache/ozone/pull/11586#issuecomment-6413394682
@adoroszlai @chungen0126 @chihsuan thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org