You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mingjie Lai (JIRA)" <ji...@apache.org> on 2011/02/08 20:53:57 UTC
[jira] Created: (HBASE-3516) Coprocessors: add test cases for
loading coprocessor jars from hdfs and local fs.
Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs.
----------------------------------------------------------------------------------
Key: HBASE-3516
URL: https://issues.apache.org/jira/browse/HBASE-3516
Project: HBase
Issue Type: Improvement
Components: coprocessors
Affects Versions: 0.90.0
Reporter: Mingjie Lai
Assignee: Mingjie Lai
Fix For: 0.90.2
Loading coprocessors classes from jar files (at hdfs or local fs) is supported from CP framework right now. We used to have a test case to cover this scenario which uses an base-64 encoded string at the test case to represent a compiled jar file. This hardcoded way was not acceptable as a valid test case, so we removed it eventually.
We need to have a better way to redo this case. Option 1) modify maven file in order to compile a test cp class into jar, and put it to hdfs and local fs, and run the cp class loading test; option 2) use Java 6.0 Compiler API to compile the test case at runtime and create the jar file?
Need more time to investigate which one is better.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3516) Coprocessors: add test cases for
loading coprocessor jars from hdfs and local fs.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-3516:
-------------------------
Fix Version/s: (was: 0.90.2)
0.92.0
Moving out of 0.90. There are no CPs in 0.90.
> Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3516
> URL: https://issues.apache.org/jira/browse/HBASE-3516
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.90.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Fix For: 0.92.0
>
>
> Loading coprocessors classes from jar files (at hdfs or local fs) is supported from CP framework right now. We used to have a test case to cover this scenario which uses an base-64 encoded string at the test case to represent a compiled jar file. This hardcoded way was not acceptable as a valid test case, so we removed it eventually.
> We need to have a better way to redo this case. Option 1) modify maven file in order to compile a test cp class into jar, and put it to hdfs and local fs, and run the cp class loading test; option 2) use Java 6.0 Compiler API to compile the test case at runtime and create the jar file?
> Need more time to investigate which one is better.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3516) Coprocessors: add test cases for
loading coprocessor jars from hdfs and local fs.
Posted by "Mingjie Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingjie Lai updated HBASE-3516:
-------------------------------
Attachment: HBase3516-2.patch
> Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3516
> URL: https://issues.apache.org/jira/browse/HBASE-3516
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.90.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Attachments: HBase3516-2.patch
>
>
> Loading coprocessors classes from jar files (at hdfs or local fs) is supported from CP framework right now. We used to have a test case to cover this scenario which uses an base-64 encoded string at the test case to represent a compiled jar file. This hardcoded way was not acceptable as a valid test case, so we removed it eventually.
> We need to have a better way to redo this case. Option 1) modify maven file in order to compile a test cp class into jar, and put it to hdfs and local fs, and run the cp class loading test; option 2) use Java 6.0 Compiler API to compile the test case at runtime and create the jar file?
> Need more time to investigate which one is better.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3516) Coprocessors: add test cases for
loading coprocessor jars from hdfs and local fs.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055002#comment-13055002 ]
jiraposter@reviews.apache.org commented on HBASE-3516:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/963/#review915
-----------------------------------------------------------
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
<https://reviews.apache.org/r/963/#comment1970>
There should be a tearDownAfterClass() which tears down the minicluster.
- Ted
On 2011-06-25 01:35:54, Mingjie Lai wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/963/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-25 01:35:54)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. There is no test case for testing coprocesors class loading from hdfs or local file system.
bq.
bq. Add test cases for cp class loading.
bq.
bq. It does:
bq. - compile a cp implementation on the fly by Java compiler api
bq. - build a jar file from the compiled classes
bq. - copy the jar to local file system or hdfs so it can be loaded for a region
bq.
bq.
bq. This addresses bug HBase-3516.
bq. https://issues.apache.org/jira/browse/HBase-3516
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 0a1fb2a
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/963/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mingjie
bq.
bq.
> Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3516
> URL: https://issues.apache.org/jira/browse/HBASE-3516
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.90.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
>
> Loading coprocessors classes from jar files (at hdfs or local fs) is supported from CP framework right now. We used to have a test case to cover this scenario which uses an base-64 encoded string at the test case to represent a compiled jar file. This hardcoded way was not acceptable as a valid test case, so we removed it eventually.
> We need to have a better way to redo this case. Option 1) modify maven file in order to compile a test cp class into jar, and put it to hdfs and local fs, and run the cp class loading test; option 2) use Java 6.0 Compiler API to compile the test case at runtime and create the jar file?
> Need more time to investigate which one is better.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3516) Coprocessors: add test cases for
loading coprocessor jars from hdfs and local fs.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055345#comment-13055345 ]
jiraposter@reviews.apache.org commented on HBASE-3516:
------------------------------------------------------
bq. On 2011-06-26 01:39:40, Ted Yu wrote:
bq. > src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java, line 74
bq. > <https://reviews.apache.org/r/963/diff/1/?file=21673#file21673line74>
bq. >
bq. > There should be a tearDownAfterClass() which tears down the minicluster.
Agree. Will add shutdownMiniCluster() at @AfterClass.
- Mingjie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/963/#review915
-----------------------------------------------------------
On 2011-06-25 01:35:54, Mingjie Lai wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/963/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-25 01:35:54)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. There is no test case for testing coprocesors class loading from hdfs or local file system.
bq.
bq. Add test cases for cp class loading.
bq.
bq. It does:
bq. - compile a cp implementation on the fly by Java compiler api
bq. - build a jar file from the compiled classes
bq. - copy the jar to local file system or hdfs so it can be loaded for a region
bq.
bq.
bq. This addresses bug HBase-3516.
bq. https://issues.apache.org/jira/browse/HBase-3516
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 0a1fb2a
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/963/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mingjie
bq.
bq.
> Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3516
> URL: https://issues.apache.org/jira/browse/HBASE-3516
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.90.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
>
> Loading coprocessors classes from jar files (at hdfs or local fs) is supported from CP framework right now. We used to have a test case to cover this scenario which uses an base-64 encoded string at the test case to represent a compiled jar file. This hardcoded way was not acceptable as a valid test case, so we removed it eventually.
> We need to have a better way to redo this case. Option 1) modify maven file in order to compile a test cp class into jar, and put it to hdfs and local fs, and run the cp class loading test; option 2) use Java 6.0 Compiler API to compile the test case at runtime and create the jar file?
> Need more time to investigate which one is better.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3516) Coprocessors: add test cases for
loading coprocessor jars from hdfs and local fs.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055346#comment-13055346 ]
jiraposter@reviews.apache.org commented on HBASE-3516:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/963/
-----------------------------------------------------------
(Updated 2011-06-27 06:05:51.067542)
Review request for hbase.
Changes
-------
Fixed 2 issues commented by Ted.
Summary
-------
There is no test case for testing coprocesors class loading from hdfs or local file system.
Add test cases for cp class loading.
It does:
- compile a cp implementation on the fly by Java compiler api
- build a jar file from the compiled classes
- copy the jar to local file system or hdfs so it can be loaded for a region
This addresses bug HBase-3516.
https://issues.apache.org/jira/browse/HBase-3516
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 0a1fb2a
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java PRE-CREATION
Diff: https://reviews.apache.org/r/963/diff
Testing
-------
Thanks,
Mingjie
> Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3516
> URL: https://issues.apache.org/jira/browse/HBASE-3516
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.90.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
>
> Loading coprocessors classes from jar files (at hdfs or local fs) is supported from CP framework right now. We used to have a test case to cover this scenario which uses an base-64 encoded string at the test case to represent a compiled jar file. This hardcoded way was not acceptable as a valid test case, so we removed it eventually.
> We need to have a better way to redo this case. Option 1) modify maven file in order to compile a test cp class into jar, and put it to hdfs and local fs, and run the cp class loading test; option 2) use Java 6.0 Compiler API to compile the test case at runtime and create the jar file?
> Need more time to investigate which one is better.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3516) Coprocessors: add test cases for
loading coprocessor jars from hdfs and local fs.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055439#comment-13055439 ]
jiraposter@reviews.apache.org commented on HBASE-3516:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/963/#review918
-----------------------------------------------------------
Ship it!
- Ted
On 2011-06-27 06:05:51, Mingjie Lai wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/963/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-27 06:05:51)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. There is no test case for testing coprocesors class loading from hdfs or local file system.
bq.
bq. Add test cases for cp class loading.
bq.
bq. It does:
bq. - compile a cp implementation on the fly by Java compiler api
bq. - build a jar file from the compiled classes
bq. - copy the jar to local file system or hdfs so it can be loaded for a region
bq.
bq.
bq. This addresses bug HBase-3516.
bq. https://issues.apache.org/jira/browse/HBase-3516
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 0a1fb2a
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/963/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mingjie
bq.
bq.
> Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3516
> URL: https://issues.apache.org/jira/browse/HBASE-3516
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.90.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
>
> Loading coprocessors classes from jar files (at hdfs or local fs) is supported from CP framework right now. We used to have a test case to cover this scenario which uses an base-64 encoded string at the test case to represent a compiled jar file. This hardcoded way was not acceptable as a valid test case, so we removed it eventually.
> We need to have a better way to redo this case. Option 1) modify maven file in order to compile a test cp class into jar, and put it to hdfs and local fs, and run the cp class loading test; option 2) use Java 6.0 Compiler API to compile the test case at runtime and create the jar file?
> Need more time to investigate which one is better.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3516) Coprocessors: add test cases for
loading coprocessor jars from hdfs and local fs.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056837#comment-13056837 ]
Hudson commented on HBASE-3516:
-------------------------------
Integrated in HBase-TRUNK #1995 (See [https://builds.apache.org/job/HBase-TRUNK/1995/])
HBASE-3516 Coprocessors: add test cases for loading coprocessor jars
garyh :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
> Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3516
> URL: https://issues.apache.org/jira/browse/HBASE-3516
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.90.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Fix For: 0.92.0
>
> Attachments: HBase3516-2.patch
>
>
> Loading coprocessors classes from jar files (at hdfs or local fs) is supported from CP framework right now. We used to have a test case to cover this scenario which uses an base-64 encoded string at the test case to represent a compiled jar file. This hardcoded way was not acceptable as a valid test case, so we removed it eventually.
> We need to have a better way to redo this case. Option 1) modify maven file in order to compile a test cp class into jar, and put it to hdfs and local fs, and run the cp class loading test; option 2) use Java 6.0 Compiler API to compile the test case at runtime and create the jar file?
> Need more time to investigate which one is better.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3516) Coprocessors: add test cases for
loading coprocessor jars from hdfs and local fs.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054795#comment-13054795 ]
jiraposter@reviews.apache.org commented on HBASE-3516:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/963/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
There is no test case for testing coprocesors class loading from hdfs or local file system.
Add test cases for cp class loading.
It does:
- compile a cp implementation on the fly by Java compiler api
- build a jar file from the compiled classes
- copy the jar to local file system or hdfs so it can be loaded for a region
This addresses bug HBase-3516.
https://issues.apache.org/jira/browse/HBase-3516
Diffs
-----
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 0a1fb2a
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java PRE-CREATION
Diff: https://reviews.apache.org/r/963/diff
Testing
-------
Thanks,
Mingjie
> Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3516
> URL: https://issues.apache.org/jira/browse/HBASE-3516
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.90.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
>
> Loading coprocessors classes from jar files (at hdfs or local fs) is supported from CP framework right now. We used to have a test case to cover this scenario which uses an base-64 encoded string at the test case to represent a compiled jar file. This hardcoded way was not acceptable as a valid test case, so we removed it eventually.
> We need to have a better way to redo this case. Option 1) modify maven file in order to compile a test cp class into jar, and put it to hdfs and local fs, and run the cp class loading test; option 2) use Java 6.0 Compiler API to compile the test case at runtime and create the jar file?
> Need more time to investigate which one is better.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-3516) Coprocessors: add test cases for
loading coprocessor jars from hdfs and local fs.
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling resolved HBASE-3516.
----------------------------------
Resolution: Fixed
Fix Version/s: 0.92.0
Committed to trunk. Thanks for the patch Mingjie. And thanks Ted and Stack for the reviews.
> Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3516
> URL: https://issues.apache.org/jira/browse/HBASE-3516
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.90.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Fix For: 0.92.0
>
> Attachments: HBase3516-2.patch
>
>
> Loading coprocessors classes from jar files (at hdfs or local fs) is supported from CP framework right now. We used to have a test case to cover this scenario which uses an base-64 encoded string at the test case to represent a compiled jar file. This hardcoded way was not acceptable as a valid test case, so we removed it eventually.
> We need to have a better way to redo this case. Option 1) modify maven file in order to compile a test cp class into jar, and put it to hdfs and local fs, and run the cp class loading test; option 2) use Java 6.0 Compiler API to compile the test case at runtime and create the jar file?
> Need more time to investigate which one is better.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3516) Coprocessors: add test cases for
loading coprocessor jars from hdfs and local fs.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056318#comment-13056318 ]
jiraposter@reviews.apache.org commented on HBASE-3516:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/963/#review926
-----------------------------------------------------------
Ship it!
Looks fine to me. If test passes, lets commit.
- Michael
On 2011-06-27 06:05:51, Mingjie Lai wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/963/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-27 06:05:51)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. There is no test case for testing coprocesors class loading from hdfs or local file system.
bq.
bq. Add test cases for cp class loading.
bq.
bq. It does:
bq. - compile a cp implementation on the fly by Java compiler api
bq. - build a jar file from the compiled classes
bq. - copy the jar to local file system or hdfs so it can be loaded for a region
bq.
bq.
bq. This addresses bug HBase-3516.
bq. https://issues.apache.org/jira/browse/HBase-3516
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 0a1fb2a
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/963/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mingjie
bq.
bq.
> Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3516
> URL: https://issues.apache.org/jira/browse/HBASE-3516
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.90.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
>
> Loading coprocessors classes from jar files (at hdfs or local fs) is supported from CP framework right now. We used to have a test case to cover this scenario which uses an base-64 encoded string at the test case to represent a compiled jar file. This hardcoded way was not acceptable as a valid test case, so we removed it eventually.
> We need to have a better way to redo this case. Option 1) modify maven file in order to compile a test cp class into jar, and put it to hdfs and local fs, and run the cp class loading test; option 2) use Java 6.0 Compiler API to compile the test case at runtime and create the jar file?
> Need more time to investigate which one is better.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3516) Coprocessors: add test cases for
loading coprocessor jars from hdfs and local fs.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054997#comment-13054997 ]
jiraposter@reviews.apache.org commented on HBASE-3516:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/963/#review914
-----------------------------------------------------------
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
<https://reviews.apache.org/r/963/#comment1969>
Class name seems to be wrong.
- Ted
On 2011-06-25 01:35:54, Mingjie Lai wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/963/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-25 01:35:54)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. There is no test case for testing coprocesors class loading from hdfs or local file system.
bq.
bq. Add test cases for cp class loading.
bq.
bq. It does:
bq. - compile a cp implementation on the fly by Java compiler api
bq. - build a jar file from the compiled classes
bq. - copy the jar to local file system or hdfs so it can be loaded for a region
bq.
bq.
bq. This addresses bug HBase-3516.
bq. https://issues.apache.org/jira/browse/HBase-3516
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 0a1fb2a
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/963/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mingjie
bq.
bq.
> Coprocessors: add test cases for loading coprocessor jars from hdfs and local fs.
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3516
> URL: https://issues.apache.org/jira/browse/HBASE-3516
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.90.0
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
>
> Loading coprocessors classes from jar files (at hdfs or local fs) is supported from CP framework right now. We used to have a test case to cover this scenario which uses an base-64 encoded string at the test case to represent a compiled jar file. This hardcoded way was not acceptable as a valid test case, so we removed it eventually.
> We need to have a better way to redo this case. Option 1) modify maven file in order to compile a test cp class into jar, and put it to hdfs and local fs, and run the cp class loading test; option 2) use Java 6.0 Compiler API to compile the test case at runtime and create the jar file?
> Need more time to investigate which one is better.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira