You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by us...@apache.org on 2012/04/15 20:36:13 UTC

svn commit: r1326390 - /lucene/dev/trunk/lucene/common-build.xml

Author: uschindler
Date: Sun Apr 15 18:36:12 2012
New Revision: 1326390

URL: http://svn.apache.org/viewvc?rev=1326390&view=rev
Log:
Fix incorrect usage of remaining macro params in junit macro

Modified:
    lucene/dev/trunk/lucene/common-build.xml

Modified: lucene/dev/trunk/lucene/common-build.xml
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/common-build.xml?rev=1326390&r1=1326389&r2=1326390&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/common-build.xml (original)
+++ lucene/dev/trunk/lucene/common-build.xml Sun Apr 15 18:36:12 2012
@@ -765,7 +765,7 @@
 
                 <!-- Emits full status for all tests, their relative order on slaves. -->
                 <report-text
-                    file="${junit.output.dir}/tests-report.txt"
+                    file="@{junit.output.dir}/tests-report.txt"
                     showThrowable="true" 
                     showStackTraces="true" 
                     showOutputStream="true" 
@@ -781,7 +781,7 @@
 
                 <!-- Emits status on errors and failures only. -->
                 <report-text
-                    file="${junit.output.dir}/tests-failures.txt"
+                    file="@{junit.output.dir}/tests-failures.txt"
                     showThrowable="true" 
                     showStackTraces="true" 
                     showOutputStream="true" 
@@ -797,11 +797,10 @@
                 
                 <!-- Emit the information about tests timings (could be used to determine
                      the slowest tests or for reuse in balancing). -->
-                <report-execution-times file="${junit.output.dir}/tests-timehints.txt" historyLength="5" />
+                <report-execution-times file="@{junit.output.dir}/tests-timehints.txt" historyLength="5" />
 
-                <!-- XML reports compatible with ant-report task. We don't use ant-report anyway so I omit these. -->
                 <report-ant-xml dir="@{junit.output.dir}" />
-                <report-json file="${junit.output.dir}/tests-report-${ant.project.name}/index.html" />
+                <report-json file="@{junit.output.dir}/tests-report-${ant.project.name}/index.html" />
             </listeners>
 
             <!-- Input test classes. -->
@@ -815,7 +814,7 @@
         <!-- Report the 5 slowest tests from this run to the console. -->
         <echo>5 slowest tests:</echo>
         <tophints max="5">
-          <file file="${junit.output.dir}/tests-timehints.txt" />
+          <file file="@{junit.output.dir}/tests-timehints.txt" />
         </tophints>
     </sequential>
   </macrodef>



Re: svn commit: r1326390 - /lucene/dev/trunk/lucene/common-build.xml

Posted by Dawid Weiss <da...@cs.put.poznan.pl>.
Ok, thanks. I didn't think about these.

Dawid

On Sun, Apr 15, 2012 at 9:00 PM, Uwe Schindler <uw...@thetaphi.de> wrote:
> I think some things like backwards compatibility tests were using those.
> --
> Uwe Schindler
> H.-H.-Meier-Allee 63, 28213 Bremen
> http://www.thetaphi.de
>
>
>
> Dawid Weiss <da...@gmail.com> schrieb:
>>
>> > -                    file="${junit.output.dir}/tests-report.txt"
>> > +                    file="@{junit.output.dir}/tests-report.txt"
>>
>> Thanks Uwe. Although these properties, strangely, always pointed to
>> the right location. I'm guessing the values passed are identical in
>> all cases so local attributes don't really matter.
>>
>> D.
>>
>> ________________________________
>>
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: svn commit: r1326390 - /lucene/dev/trunk/lucene/common-build.xml

Posted by Uwe Schindler <uw...@thetaphi.de>.
I think some things like backwards compatibility tests were using those.
--
Uwe Schindler
H.-H.-Meier-Allee 63, 28213 Bremen
http://www.thetaphi.de



Dawid Weiss <da...@gmail.com> schrieb:

> -                    file="${junit.output.dir}/tests-report.txt"
> +                    file="@{junit.output.dir}/tests-report.txt"

Thanks Uwe. Although these properties, strangely, always pointed to
the right location. I'm guessing the values passed are identical in
all cases so local attributes don't really matter.

D.

_____________________________________________

To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: svn commit: r1326390 - /lucene/dev/trunk/lucene/common-build.xml

Posted by Dawid Weiss <da...@gmail.com>.
> -                    file="${junit.output.dir}/tests-report.txt"
> +                    file="@{junit.output.dir}/tests-report.txt"

Thanks Uwe. Although these properties, strangely, always pointed to
the right location. I'm guessing the values passed are identical in
all cases so local attributes don't really matter.

D.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org