[jira] [Commented] (AIRFLOW-7074) [RBAC UI] No Permissions to view SubDAGs

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061186#comment-17061186 ] 

ASF GitHub Bot commented on AIRFLOW-7074:
-----------------------------------------

kaxil commented on pull request #7752: [AIRFLOW-7074] Add Permissions to view SubDAGs
URL: https://github.com/apache/airflow/pull/7752
 
 
   There is no granular permission for SubDags at all.
   Currently the only time you would be able to view SubDAGs would be when you can view all DAGs.
   
   So even though a user might have the permission to view a DAG, they won't be able to view SubDag
   
   I am not sure the reason why SubDags were excluded originally
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [RBAC UI] No Permissions to view SubDAGs
> ----------------------------------------
>
>                 Key: AIRFLOW-7074
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-7074
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: security, webserver
>    Affects Versions: 1.10.9
>            Reporter: Kaxil Naik
>            Priority: Major
>             Fix For: 2.0.0, 1.10.10
>
>         Attachments: Patch, image (1).png
>
>
> There is no granular permission for SubDags at all.
> https://github.com/apache/airflow/blob/ae035cdb69c76eb7070629d00ded294510df1214/airflow/www/security.py#L383
> https://github.com/apache/airflow/blob/ae035cdb69c76eb7070629d00ded294510df1214/airflow/www/security.py#L407
> Currently the only time you would be able to view SubDAGs would be when you can view all DAGs 
> ---
> A question for solving this is "Do we want to grant read permissions to all the SubDags automatically when permissions are added for the Parent DAG"?
> Or would we like to add specific permissions for SubDag too?
> Check the attachment for a patch to allow adding permissions for a SubDag too. *image (1).png* is the screenshot after applying the patch



--
This message was sent by Atlassian Jira
(v8.3.4#803005)