You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/18 07:50:01 UTC

[GitHub] [ratis-thirdparty] codings-dan opened a new pull request, #39: RATIS-1679. Do not exclud io.perfmark:perfmark-api in ratis-thirdparty

codings-dan opened a new pull request, #39:
URL: https://github.com/apache/ratis-thirdparty/pull/39

   see https://issues.apache.org/jira/browse/RATIS-1679


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis-thirdparty] szetszwo commented on a diff in pull request #39: RATIS-1679. Shade io.perfmark:perfmark-api in ratis-thirdparty

Posted by GitBox <gi...@apache.org>.
szetszwo commented on code in PR #39:
URL: https://github.com/apache/ratis-thirdparty/pull/39#discussion_r949406702


##########
pom.xml:
##########
@@ -175,6 +178,11 @@
         <artifactId>metrics-ganglia</artifactId>
         <version>${shaded.dropwizard.ganglia.version}</version>
       </dependency>
+      <dependency>
+        <groupId>io.perfmark</groupId>
+        <artifactId>perfmark-api</artifactId>
+        <version>${shaded.perfmark.version}</version>
+      </dependency>

Review Comment:
   The io.perfmark dependency comes with gRPC so that we don't have add it here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis-thirdparty] codings-dan commented on a diff in pull request #39: RATIS-1679. Shade io.perfmark:perfmark-api in ratis-thirdparty

Posted by GitBox <gi...@apache.org>.
codings-dan commented on code in PR #39:
URL: https://github.com/apache/ratis-thirdparty/pull/39#discussion_r949732719


##########
pom.xml:
##########
@@ -175,6 +178,11 @@
         <artifactId>metrics-ganglia</artifactId>
         <version>${shaded.dropwizard.ganglia.version}</version>
       </dependency>
+      <dependency>
+        <groupId>io.perfmark</groupId>
+        <artifactId>perfmark-api</artifactId>
+        <version>${shaded.perfmark.version}</version>
+      </dependency>

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis-thirdparty] codings-dan commented on pull request #39: RATIS-1679. Shade io.perfmark:perfmark-api in ratis-thirdparty

Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #39:
URL: https://github.com/apache/ratis-thirdparty/pull/39#issuecomment-1220244565

   @szetszwo Thanks for helping review the pull request!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis-thirdparty] codings-dan commented on pull request #39: RATIS-1679. Shade io.perfmark:perfmark-api in ratis-thirdparty

Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #39:
URL: https://github.com/apache/ratis-thirdparty/pull/39#issuecomment-1220154545

   @szetszwo Thanks for helping review the pull request, I have updated it, please take a look. Also thanks @adoroszlai for helping review and test it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis-thirdparty] codings-dan commented on pull request #39: RATIS-1679. Do not exclud io.perfmark:perfmark-api in ratis-thirdparty

Posted by GitBox <gi...@apache.org>.
codings-dan commented on PR #39:
URL: https://github.com/apache/ratis-thirdparty/pull/39#issuecomment-1219164389

   @szetszwo Could you help take a look at this pull request? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis-thirdparty] codings-dan merged pull request #39: RATIS-1679. Shade io.perfmark:perfmark-api in ratis-thirdparty

Posted by GitBox <gi...@apache.org>.
codings-dan merged PR #39:
URL: https://github.com/apache/ratis-thirdparty/pull/39


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org