You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Luke Han <lu...@gmail.com> on 2015/05/29 10:51:59 UTC
[VOTE] Release Apache Kylin-0.7.1-incubating
Hi all,
The Apache Kylin community has voted on and approved a proposal to release
Apache Kylin 0.7.1 (incubating), the first release of Apache Kylin.
Since this is first release after join Apache Incubating project, we would
like to hear more feedback from incubator community and please help to
verify and vote our release candidate.
Proposal:
http://s.apache.org/kylin-0.7.1-vote
Vote result:
3 binding +1 votes
0 non-binding +1 votes
No -1 votes
http://s.apache.org/kylin-0.7.1-result
The commit to be voted upon:
https://github.com/apache/incubator-kylin/commit/76b5d37561879140e73c9179d95a4e5e96751444
Its hash is 76b5d37561879140e73c9179d95a4e5e96751444.
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/incubator/kylin/apache-kylin-0.7.1-incubating-rc2/
The hashes of the artifacts are as follows:
src.zip.md5 c8b0bb6744288f07ad625cc48521b088
src.zip.sha1 bafab62d5df6e77da0f236b9399a674abcc2b34a
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachekylin-1004/
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/lukehan.asc
Pursuant to the Releases section of the Incubation Policy and with
the endorsement of our mentors we would now like to request
the permission of the Incubator PMC to publish the release. The vote
is open for 72 hours, or until the necessary number of votes (3 +1)
is reached.
[ ] +1 Release this package
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Luke Han, on behalf of Apache Kylin PPMC
Re: [VOTE] Release Apache Kylin-0.7.1-incubating
Posted by Ted Dunning <te...@gmail.com>.
On Sat, May 30, 2015 at 7:05 AM, Luke Han <lu...@gmail.com> wrote:
> According these, should we re-generate another release candidate and
> vote again, or could we go with this RC2 ?
>
> Really would like to learn and know more feedback from community for
> our first release.
>
Better to fix the first release. The whole point is to learn how to do
this right.
Re: [VOTE] Release Apache Kylin-0.7.1-incubating
Posted by "P. Taylor Goetz" <pt...@gmail.com>.
> On May 31, 2015, at 9:35 AM, Luke Han <lu...@gmail.com> wrote:
>
> And, should I cancel this vote thread or just update information here when
> new RC is ready for vote again?
It's best to cancel and start a new VOTE, it helps avoid confusion.
-Taylor
>
> Thanks.
>
> Luke
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Kylin-0.7.1-incubating
Posted by Justin Mclean <ju...@me.com>.
Hi,
> Please refer to *TrieDictionaryTest* class for more detail about how to generate and used for test.
It seem the line(s) in question to load that dictionary are comment out.
// InputStream is =
// Util.getPackageResourceAsStream(TrieDictionaryTest.class,
// "eng_com.dic");
My question is where did the original data in the file come from? For context - a lot of dictionaries (while they may just be list of words) are in fact licensed and protected by copyright and it may be that this list came from something whose license is not comparable with the Apache license.
Given that it does’t seem to be used perhaps it best to remove the file if it is unclear or unknown what it's source was?
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Kylin-0.7.1-incubating
Posted by Luke Han <lu...@gmail.com>.
>> The eng_com.dic is generated dictionary file by our code.
>How is that generated? What does it use as its source material?
Please refer to *TrieDictionaryTest* class for more detail about how to
generate and used for test.
It contains some english characters, here are some lines which you can tail
from this file:
*ventriculocisternostomies*
*ethylenediaminetetraacetic*
*laryngotracheobronchitides*
*meningoencephalomyelitides*
*pneumoencephalographically*
*electroencephalographically*
*microspectrophotometrically*
*octamethylpyrophosphoramide*
*antidisestablishmentarianism*
*dichlorodiphenyltrichloroethane*
Hope this will bring more clear about this file's purpose:)
Thanks.
Luke
Best Regards!
---------------------
Luke Han
2015-05-31 21:35 GMT+08:00 Luke Han <lu...@gmail.com>:
> Thanks all to help on this. We are working on a new release candidate with
> those issues fixed.
>
> And, should I cancel this vote thread or just update information here when
> new RC is ready for vote again?
>
> Thanks.
>
> Luke
>
>
> Best Regards!
> ---------------------
>
> Luke Han
>
> 2015-05-31 7:01 GMT+08:00 Henry Saputra <he...@gmail.com>:
>
>> Thanks Justin for valuable feedbacks.
>> Let's cancel this one and resolve some blocking issues to spin another RC.
>>
>> - Henry
>>
>>
>>
>> On Saturday, May 30, 2015, Justin Mclean <ju...@classsoftware.com>
>> wrote:
>>
>> > Hi,
>> >
>> > > Most issues are relative to website content used for
>> > > kylin.incubator.apache.org site which should be excluded from the
>> > release
>> > > package.
>> >
>> > Sounds best to make and vote on another RC if you don’t want this
>> content
>> > in the RC.
>> >
>> > If you have any questions or are unsure of anything just ask.
>> >
>> > > The eng_com.dic is generated dictionary file by our code.
>> >
>> > How is that generated? What does it use as its source material?
>> >
>> > > According these, should we re-generate another release candidate
>> and
>> > > vote again, or could we go with this RC2 ?
>> >
>> > It depends on how other IPMC members vote, you need 3+1s and more +1s
>> than
>> > -1s for a release. If you think it won’t get 3+1s, you would need to
>> cancel
>> > this vote and than generate another RC and vote on it on your dev list
>> and
>> > then put it up for vote by the IPMC here. [1]
>> >
>> > Thanks,
>> > Justin
>> >
>> > 1.
>> http://incubator.apache.org/incubation/Incubation_Policy.html#Releases
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> > <javascript:;>
>> > For additional commands, e-mail: general-help@incubator.apache.org
>> > <javascript:;>
>> >
>> >
>>
>
>
Re: [VOTE] Release Apache Kylin-0.7.1-incubating
Posted by Luke Han <lu...@gmail.com>.
Thanks all to help on this. We are working on a new release candidate with
those issues fixed.
And, should I cancel this vote thread or just update information here when
new RC is ready for vote again?
Thanks.
Luke
Best Regards!
---------------------
Luke Han
2015-05-31 7:01 GMT+08:00 Henry Saputra <he...@gmail.com>:
> Thanks Justin for valuable feedbacks.
> Let's cancel this one and resolve some blocking issues to spin another RC.
>
> - Henry
>
>
>
> On Saturday, May 30, 2015, Justin Mclean <ju...@classsoftware.com> wrote:
>
> > Hi,
> >
> > > Most issues are relative to website content used for
> > > kylin.incubator.apache.org site which should be excluded from the
> > release
> > > package.
> >
> > Sounds best to make and vote on another RC if you don’t want this content
> > in the RC.
> >
> > If you have any questions or are unsure of anything just ask.
> >
> > > The eng_com.dic is generated dictionary file by our code.
> >
> > How is that generated? What does it use as its source material?
> >
> > > According these, should we re-generate another release candidate and
> > > vote again, or could we go with this RC2 ?
> >
> > It depends on how other IPMC members vote, you need 3+1s and more +1s
> than
> > -1s for a release. If you think it won’t get 3+1s, you would need to
> cancel
> > this vote and than generate another RC and vote on it on your dev list
> and
> > then put it up for vote by the IPMC here. [1]
> >
> > Thanks,
> > Justin
> >
> > 1.
> http://incubator.apache.org/incubation/Incubation_Policy.html#Releases
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > <javascript:;>
> > For additional commands, e-mail: general-help@incubator.apache.org
> > <javascript:;>
> >
> >
>
Re: [VOTE] Release Apache Kylin-0.7.1-incubating
Posted by Henry Saputra <he...@gmail.com>.
Thanks Justin for valuable feedbacks.
Let's cancel this one and resolve some blocking issues to spin another RC.
- Henry
On Saturday, May 30, 2015, Justin Mclean <ju...@classsoftware.com> wrote:
> Hi,
>
> > Most issues are relative to website content used for
> > kylin.incubator.apache.org site which should be excluded from the
> release
> > package.
>
> Sounds best to make and vote on another RC if you don’t want this content
> in the RC.
>
> If you have any questions or are unsure of anything just ask.
>
> > The eng_com.dic is generated dictionary file by our code.
>
> How is that generated? What does it use as its source material?
>
> > According these, should we re-generate another release candidate and
> > vote again, or could we go with this RC2 ?
>
> It depends on how other IPMC members vote, you need 3+1s and more +1s than
> -1s for a release. If you think it won’t get 3+1s, you would need to cancel
> this vote and than generate another RC and vote on it on your dev list and
> then put it up for vote by the IPMC here. [1]
>
> Thanks,
> Justin
>
> 1. http://incubator.apache.org/incubation/Incubation_Policy.html#Releases
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> <javascript:;>
> For additional commands, e-mail: general-help@incubator.apache.org
> <javascript:;>
>
>
Re: [VOTE] Release Apache Kylin-0.7.1-incubating
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Most issues are relative to website content used for
> kylin.incubator.apache.org site which should be excluded from the release
> package.
Sounds best to make and vote on another RC if you don’t want this content in the RC.
If you have any questions or are unsure of anything just ask.
> The eng_com.dic is generated dictionary file by our code.
How is that generated? What does it use as its source material?
> According these, should we re-generate another release candidate and
> vote again, or could we go with this RC2 ?
It depends on how other IPMC members vote, you need 3+1s and more +1s than -1s for a release. If you think it won’t get 3+1s, you would need to cancel this vote and than generate another RC and vote on it on your dev list and then put it up for vote by the IPMC here. [1]
Thanks,
Justin
1. http://incubator.apache.org/incubation/Incubation_Policy.html#Releases
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Kylin-0.7.1-incubating
Posted by Luke Han <lu...@gmail.com>.
Thanks Justin,
Most issues are relative to website content used for
kylin.incubator.apache.org site which should be excluded from the release
package. Will also check and fix such issue even they not be included in
further release.
The binary file, hbase mini cluster, is included for testing purpose.
The eng_com.dic is generated dictionary file by our code.
Other issue will be fixed soon.
According these, should we re-generate another release candidate and
vote again, or could we go with this RC2 ?
Really would like to learn and know more feedback from community for
our first release.
Thank you very much.
Luke
Best Regards!
---------------------
Luke Han
2015-05-30 10:17 GMT+08:00 Justin Mclean <ju...@classsoftware.com>:
> Hi,
>
> Sorry but it’s -1 binding form me:
> - LICENSE is incorrect and missing 3rd party bundled software
> - Incorrect Apache license headers added to files under other licenses
> - Possible font licensing issues.
>
> Unless that is other IPMC member this it ok to fix these issue in a future
> release and I’ll consider changing my vote.
>
> I checked:
> - incubating in file name
> - DISCLAIMER exists
> - hashes and signatures correct
> - LICENSE and NOTICE issues (see below)
> - All source file have Apache headers
> - One unexpected binary file, but it used for testing
>
> LICENSE is missing information on the bundled versions of font awesome,
> bootstrap, jQuery and normalize.css, See:
> ./kylin-0.7.1-incubating/docs/website/assets/css/font-awesome.min.css
> ./kylin-0.7.1-incubating/docs/website/assets/js/bootstrap.min.js
> ./kylin-0.7.1-incubating/docs/website/assets/js/jquery-1.9.1.min.js
>
> I assuming these were not picked up because the mvn rat target is ignoring
> the docs directory?
>
> See [1] on how to add these permissive licenses to LICENSE.
>
> Looks like there may be some font licensing issues - for instance this
> file:
>
> ./kylin-0.7.1-incubating/docs/website/assets/fonts/helveticaneue-webfont.svg
>
> Which an Apache header has been incorrectly added to(?)
>
> Contains this text:
>
> Created by FontForge 20110222 at Thu Mar 6 12:16:42 2014
> By Orthosie Webhosting
> Copyright (c) 1981, 1982, 1983, 1989 and 1993, Linotype Library GmbH or
> its affiliated Linotype-Hell companies. All rights reserved.
>
> The digitally encoded machine readable software for producing the
> Typefaces licensed to you is now the property of Heidelberger
> Druckmaschinen AG and its licensors, and may not be reproduced, used,
> displayed, modified, disclosed or transferred without the express written
> approval of Heidelberger Druckmaschinen AG.
>
> Copyright (c) 1988, 1990, 1993 Adobe Systems Incorporated. All Rights
> Reserved.
>
> Also this file:
> ./docs/website/assets/css/animate.css
>
> Has had a Apache license added when it is MIT licensed. It’s information
> should also be added into the LICENSE file.
>
> Some other minor issues:
> -There are a few test and doc files without apache header that it could
> probably be added to.
> -There is an archive which also look like it use for testing. Does this
> need to be distributed in the source repo?
>
> ./kylin-0.7.1-incubating/examples/test_case_data/minicluster/hbase-export.tar.gz
> - Can I ask where this file came from and what license was it original
> under?
>
> ./kylin-0.7.1-incubating/dictionary/src/test/resources/dict/eng_com.dic
>
> There are also there two binary font files - who licensing I’m unsure of:
>
> ./kylin-0.7.1-incubating/webapp/app/fonts/ODelI1aHBYDBqgeIAH2zlPytCVloACqnDHJwh-em2k8.woff2
> (may be Source San Pro which is covered by a SIL license so that would
> also need to go into the LICENSE file or be removed)
>
> ./kylin-0.7.1-incubating/webapp/app/fonts/toadOcfmlt9b38dHJxOBGKUt5Ot5NIMarvNW-hkYWvT3rGVtsTkPsbDajuO5ueQw.woff2
> (may be Source Sans Pro Bold?)
>
> Can you also fix:
> - LICENSE is missing the appendix from the standard license [2] can this
> be added.
> - The NOTICE file should have the project name as “Apache Kylin"
>
> Thanks,
> Justin
>
> 1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
> 2. http://www.apache.org/licenses/LICENSE-2.0.txt
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache Kylin-0.7.1-incubating
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Sorry but it’s -1 binding form me:
- LICENSE is incorrect and missing 3rd party bundled software
- Incorrect Apache license headers added to files under other licenses
- Possible font licensing issues.
Unless that is other IPMC member this it ok to fix these issue in a future release and I’ll consider changing my vote.
I checked:
- incubating in file name
- DISCLAIMER exists
- hashes and signatures correct
- LICENSE and NOTICE issues (see below)
- All source file have Apache headers
- One unexpected binary file, but it used for testing
LICENSE is missing information on the bundled versions of font awesome, bootstrap, jQuery and normalize.css, See:
./kylin-0.7.1-incubating/docs/website/assets/css/font-awesome.min.css
./kylin-0.7.1-incubating/docs/website/assets/js/bootstrap.min.js
./kylin-0.7.1-incubating/docs/website/assets/js/jquery-1.9.1.min.js
I assuming these were not picked up because the mvn rat target is ignoring the docs directory?
See [1] on how to add these permissive licenses to LICENSE.
Looks like there may be some font licensing issues - for instance this file:
./kylin-0.7.1-incubating/docs/website/assets/fonts/helveticaneue-webfont.svg
Which an Apache header has been incorrectly added to(?)
Contains this text:
Created by FontForge 20110222 at Thu Mar 6 12:16:42 2014
By Orthosie Webhosting
Copyright (c) 1981, 1982, 1983, 1989 and 1993, Linotype Library GmbH or its affiliated Linotype-Hell companies. All rights reserved.
The digitally encoded machine readable software for producing the Typefaces licensed to you is now the property of Heidelberger Druckmaschinen AG and its licensors, and may not be reproduced, used, displayed, modified, disclosed or transferred without the express written approval of Heidelberger Druckmaschinen AG.
Copyright (c) 1988, 1990, 1993 Adobe Systems Incorporated. All Rights Reserved.
Also this file:
./docs/website/assets/css/animate.css
Has had a Apache license added when it is MIT licensed. It’s information should also be added into the LICENSE file.
Some other minor issues:
-There are a few test and doc files without apache header that it could probably be added to.
-There is an archive which also look like it use for testing. Does this need to be distributed in the source repo?
./kylin-0.7.1-incubating/examples/test_case_data/minicluster/hbase-export.tar.gz
- Can I ask where this file came from and what license was it original under?
./kylin-0.7.1-incubating/dictionary/src/test/resources/dict/eng_com.dic
There are also there two binary font files - who licensing I’m unsure of:
./kylin-0.7.1-incubating/webapp/app/fonts/ODelI1aHBYDBqgeIAH2zlPytCVloACqnDHJwh-em2k8.woff2
(may be Source San Pro which is covered by a SIL license so that would also need to go into the LICENSE file or be removed)
./kylin-0.7.1-incubating/webapp/app/fonts/toadOcfmlt9b38dHJxOBGKUt5Ot5NIMarvNW-hkYWvT3rGVtsTkPsbDajuO5ueQw.woff2
(may be Source Sans Pro Bold?)
Can you also fix:
- LICENSE is missing the appendix from the standard license [2] can this be added.
- The NOTICE file should have the project name as “Apache Kylin"
Thanks,
Justin
1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
2. http://www.apache.org/licenses/LICENSE-2.0.txt
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org