Re: [PR] [CELEBORN-1574] Speed up unregister shuffle by batch processing [celeborn]

["zaynt4606 (via GitHub)" <gi...@apache.org>]

zaynt4606 commented on code in PR #2701:
URL: https://github.com/apache/celeborn/pull/2701#discussion_r1740264194


##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -978,6 +988,25 @@ private[celeborn] class Master(
     context.reply(UnregisterShuffleResponse(StatusCode.SUCCESS))
   }
 
+  def batchHandleUnregisterShuffles(
+      context: RpcCallContext,
+      applicationId: String,
+      shuffleIds: List[Integer],
+      requestId: String): Unit = {
+    val map = JavaUtils.newConcurrentHashMap[Integer, StatusCode]()
+    val shuffleKeys = new util.ArrayList[String]()
+    shuffleIds.foreach { shuffleId =>
+      val shuffleKey = Utils.makeShuffleKey(applicationId, shuffleId)
+      shuffleKeys.add(shuffleKey)
+    }
+    statusSystem.batchHandleUnRegisterShuffles(shuffleKeys, requestId)
+    logInfo(s"Unregister shuffle $shuffleKeys")
+    shuffleIds.foreach { shuffleId =>
+      map.put(shuffleId, StatusCode.SUCCESS)
+    }
+    context.reply(BatchUnregisterShuffleResponses(StatusCode.SUCCESS, map))

Review Comment:
   Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org