You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by gi...@git.apache.org on 2017/05/17 06:08:07 UTC

[GitHub] anshul1886 commented on a change in pull request #868: CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic scaling if new service offering has different vGPU type

anshul1886 commented on a change in pull request #868: CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic scaling if new service offering has different vGPU type
URL: https://github.com/apache/cloudstack/pull/868#discussion_r116916907
 
 

 ##########
 File path: server/src/com/cloud/vm/UserVmManagerImpl.java
 ##########
 @@ -1661,6 +1661,19 @@ private boolean upgradeRunningVirtualMachine(Long vmId, Long newServiceOfferingI
                     + ",memory=," + currentMemory + ")");
         }
 
+        _offeringDao.loadDetails(currentServiceOffering);
 
 Review comment:
   @nitin-maharana This check will be redundant as there is no place where details are getting set in variable's lifetime.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services