You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rc...@apache.org on 2020/06/08 03:12:22 UTC

[james-project] 01/16: JAMES-3196 Add toString() for IMAP commands

This is an automated email from the ASF dual-hosted git repository.

rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit a984dbf9fd1c7ed156be0abf5daa8cd55d92717d
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Thu May 28 11:28:50 2020 +0700

    JAMES-3196 Add toString() for IMAP commands
---
 .../james/imap/api/message/request/SearchOperation.java   |  1 +
 .../apache/james/imap/message/request/AppendRequest.java  | 11 +++++++++++
 .../james/imap/message/request/AuthenticateRequest.java   |  9 +++++++++
 .../apache/james/imap/message/request/CopyRequest.java    | 11 +++++++++++
 .../apache/james/imap/message/request/CreateRequest.java  |  9 +++++++++
 .../james/imap/message/request/DeleteACLRequest.java      |  9 +++++++++
 .../apache/james/imap/message/request/DeleteRequest.java  |  9 +++++++++
 .../apache/james/imap/message/request/EnableRequest.java  |  9 +++++++++
 .../apache/james/imap/message/request/ExamineRequest.java | 14 ++++++++++++++
 .../apache/james/imap/message/request/ExpungeRequest.java |  8 ++++++++
 .../apache/james/imap/message/request/FetchRequest.java   | 10 ++++++++++
 .../apache/james/imap/message/request/GetACLRequest.java  |  8 ++++++++
 .../james/imap/message/request/GetAnnotationRequest.java  | 11 +++++++++++
 .../james/imap/message/request/GetQuotaRequest.java       |  8 ++++++++
 .../james/imap/message/request/GetQuotaRootRequest.java   |  8 ++++++++
 .../apache/james/imap/message/request/ListRequest.java    | 10 ++++++++++
 .../james/imap/message/request/ListRightsRequest.java     |  9 +++++++++
 .../apache/james/imap/message/request/LoginRequest.java   |  9 +++++++++
 .../apache/james/imap/message/request/LsubRequest.java    | 10 ++++++++++
 .../apache/james/imap/message/request/MoveRequest.java    | 10 ++++++++++
 .../james/imap/message/request/MyRightsRequest.java       |  9 +++++++++
 .../apache/james/imap/message/request/RenameRequest.java  | 10 ++++++++++
 .../apache/james/imap/message/request/SearchRequest.java  | 10 ++++++++++
 .../apache/james/imap/message/request/SelectRequest.java  | 15 +++++++++++++++
 .../apache/james/imap/message/request/SetACLRequest.java  | 10 ++++++++++
 .../james/imap/message/request/SetAnnotationRequest.java  |  8 ++++++++
 .../james/imap/message/request/SetQuotaRequest.java       |  8 ++++++++
 .../apache/james/imap/message/request/StatusRequest.java  | 10 ++++++++++
 .../james/imap/message/request/SubscribeRequest.java      |  9 +++++++++
 .../james/imap/message/request/UnselectRequest.java       |  8 ++++++++
 .../james/imap/message/request/UnsubscribeRequest.java    |  9 +++++++++
 31 files changed, 289 insertions(+)

diff --git a/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/SearchOperation.java b/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/SearchOperation.java
index 44558b2..5333ac1 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/SearchOperation.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/SearchOperation.java
@@ -46,6 +46,7 @@ public final class SearchOperation {
     public String toString() {
         return MoreObjects.toStringHelper(this)
             .add("key", key)
+            .add("options", options)
             .toString();
     }
  
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/AppendRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/AppendRequest.java
index 839bcea..f60bdaa 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/AppendRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/AppendRequest.java
@@ -27,6 +27,8 @@ import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 import org.apache.james.imap.api.message.request.ImapRequest;
 
+import com.google.common.base.MoreObjects;
+
 /**
  * {@link ImapRequest} which request the append of a message to a mailbox
  */
@@ -80,4 +82,13 @@ public class AppendRequest extends AbstractImapRequest {
         return message;
     }
 
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("mailboxName", mailboxName)
+            .add("flags", flags)
+            .add("datetime", datetime)
+            .add("message", message)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/AuthenticateRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/AuthenticateRequest.java
index 6bb79f8..7bb2df1 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/AuthenticateRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/AuthenticateRequest.java
@@ -21,6 +21,8 @@ package org.apache.james.imap.message.request;
 import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 
+import com.google.common.base.MoreObjects;
+
 public class AuthenticateRequest extends AbstractImapRequest {
     private final String authType;
 
@@ -32,4 +34,11 @@ public class AuthenticateRequest extends AbstractImapRequest {
     public final String getAuthType() {
         return authType;
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("authType", authType)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/CopyRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/CopyRequest.java
index c136aaf..2329b27 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/CopyRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/CopyRequest.java
@@ -23,6 +23,8 @@ import org.apache.james.imap.api.Tag;
 import org.apache.james.imap.api.message.IdRange;
 import org.apache.james.imap.api.message.request.ImapRequest;
 
+import com.google.common.base.MoreObjects;
+
 /**
  * {@link ImapRequest} which request the copy of messages
  */
@@ -30,4 +32,13 @@ public class CopyRequest extends AbstractMessageRangeRequest {
     public CopyRequest(IdRange[] idSet, String mailboxName, boolean useUids, Tag tag) {
         super(ImapConstants.COPY_COMMAND, idSet, mailboxName, useUids, tag);
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("idSet", getIdSet())
+            .add("mailboxName", getMailboxName())
+            .add("useUids", isUseUids())
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/CreateRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/CreateRequest.java
index 6f85aa1..780c0e1 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/CreateRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/CreateRequest.java
@@ -22,6 +22,8 @@ import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 import org.apache.james.imap.api.message.request.ImapRequest;
 
+import com.google.common.base.MoreObjects;
+
 /**
  * {@link ImapRequest} which request the creation of a mailbox
  */
@@ -41,4 +43,11 @@ public class CreateRequest extends AbstractImapRequest {
     public final String getMailboxName() {
         return mailboxName;
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("mailboxName", mailboxName)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/DeleteACLRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/DeleteACLRequest.java
index ea7f824..192133c 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/DeleteACLRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/DeleteACLRequest.java
@@ -22,6 +22,8 @@ package org.apache.james.imap.message.request;
 import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 
+import com.google.common.base.MoreObjects;
+
 /**
  * DELETEACL Request.
  */
@@ -43,4 +45,11 @@ public class DeleteACLRequest extends AbstractImapRequest {
         return mailboxName;
     }
 
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("mailboxName", mailboxName)
+            .add("identifier", identifier)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/DeleteRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/DeleteRequest.java
index 20900b6..4d9a42d 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/DeleteRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/DeleteRequest.java
@@ -22,6 +22,8 @@ import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 import org.apache.james.imap.api.message.request.ImapRequest;
 
+import com.google.common.base.MoreObjects;
+
 /**
  * {@link ImapRequest} which request the deletion of a mailbox
  */
@@ -41,4 +43,11 @@ public class DeleteRequest extends AbstractImapRequest {
     public final String getMailboxName() {
         return mailboxName;
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("mailboxName", mailboxName)
+            .toString();
+    }
 }
\ No newline at end of file
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/EnableRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/EnableRequest.java
index e9e1efe..d92296e 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/EnableRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/EnableRequest.java
@@ -24,6 +24,8 @@ import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 import org.apache.james.imap.api.message.Capability;
 
+import com.google.common.base.MoreObjects;
+
 public class EnableRequest extends AbstractImapRequest {
 
     private final List<Capability> capabilities;
@@ -41,4 +43,11 @@ public class EnableRequest extends AbstractImapRequest {
     public List<Capability> getCapabilities() {
         return capabilities;
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("capabilities", capabilities)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/ExamineRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/ExamineRequest.java
index 208c0d9..969f6b5 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/ExamineRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/ExamineRequest.java
@@ -23,9 +23,23 @@ import org.apache.james.imap.api.Tag;
 import org.apache.james.imap.api.message.IdRange;
 import org.apache.james.imap.api.message.UidRange;
 
+import com.google.common.base.MoreObjects;
+
 public class ExamineRequest extends AbstractMailboxSelectionRequest {
     public ExamineRequest(String mailboxName, boolean condstore, ClientSpecifiedUidValidity lastKnownUidValidity, Long knownModSeq, UidRange[] uidSet, UidRange[] knownUidSet, IdRange[] knownSequenceSet, Tag tag) {
         super(ImapConstants.EXAMINE_COMMAND, mailboxName, condstore, lastKnownUidValidity, knownModSeq, uidSet, knownUidSet, knownSequenceSet, tag);
     }
 
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("mailboxName", getMailboxName())
+            .add("condstore", getCondstore())
+            .add("lastKnownUidValidity", getLastKnownUidValidity())
+            .add("knownModSeq", getKnownModSeq())
+            .add("uidSet", getUidSet())
+            .add("knownUidSet", getKnownUidSet())
+            .add("knownSequenceSet", getKnownSequenceSet())
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/ExpungeRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/ExpungeRequest.java
index 461415e..fd31e27 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/ExpungeRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/ExpungeRequest.java
@@ -23,6 +23,8 @@ import org.apache.james.imap.api.Tag;
 import org.apache.james.imap.api.message.IdRange;
 import org.apache.james.imap.api.message.request.ImapRequest;
 
+import com.google.common.base.MoreObjects;
+
 /**
  * {@link ImapRequest} which requests expunge of deleted messages
  */
@@ -44,4 +46,10 @@ public class ExpungeRequest extends AbstractImapRequest {
         return uidRange;
     }
 
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("uidRange", uidRange)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/FetchRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/FetchRequest.java
index 9dce8ee..b5e088f 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/FetchRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/FetchRequest.java
@@ -23,6 +23,8 @@ import org.apache.james.imap.api.Tag;
 import org.apache.james.imap.api.message.FetchData;
 import org.apache.james.imap.api.message.IdRange;
 
+import com.google.common.base.MoreObjects;
+
 public class FetchRequest extends AbstractImapRequest {
     private final boolean useUids;
     private final IdRange[] idSet;
@@ -47,4 +49,12 @@ public class FetchRequest extends AbstractImapRequest {
         return useUids;
     }
 
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("useUids", useUids)
+            .add("idSet", idSet)
+            .add("fetch", fetch)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetACLRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetACLRequest.java
index d11262b..4a0da7f 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetACLRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetACLRequest.java
@@ -22,6 +22,8 @@ package org.apache.james.imap.message.request;
 import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 
+import com.google.common.base.MoreObjects;
+
 /**
  * GETACL Request.
  */
@@ -37,4 +39,10 @@ public class GetACLRequest extends AbstractImapRequest {
         return mailboxName;
     }
 
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("mailboxName", mailboxName)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetAnnotationRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetAnnotationRequest.java
index 84f2902..46b6102 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetAnnotationRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetAnnotationRequest.java
@@ -26,6 +26,7 @@ import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 import org.apache.james.mailbox.model.MailboxAnnotationKey;
 
+import com.google.common.base.MoreObjects;
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableSet;
 
@@ -150,4 +151,14 @@ public class GetAnnotationRequest extends AbstractImapRequest {
             throw new IllegalArgumentException("Cannot lookup Depth data for: " + code);
         }
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("mailboxName", mailboxName)
+            .add("keys", keys)
+            .add("maxsize", maxsize)
+            .add("depth", depth)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetQuotaRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetQuotaRequest.java
index 1760066..0e2d401 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetQuotaRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetQuotaRequest.java
@@ -22,6 +22,8 @@ package org.apache.james.imap.message.request;
 import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 
+import com.google.common.base.MoreObjects;
+
 /**
  * GETQUOTA Request
  */
@@ -37,4 +39,10 @@ public class GetQuotaRequest extends AbstractImapRequest {
         return quotaRoot;
     }
 
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("quotaRoot", quotaRoot)
+            .toString();
+    }
 }
\ No newline at end of file
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetQuotaRootRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetQuotaRootRequest.java
index b4c3d1f..cd1d4b6 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetQuotaRootRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/GetQuotaRootRequest.java
@@ -22,6 +22,8 @@ package org.apache.james.imap.message.request;
 import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 
+import com.google.common.base.MoreObjects;
+
 /**
  * GETQUOTAROOT Request
  */
@@ -37,4 +39,10 @@ public class GetQuotaRootRequest extends AbstractImapRequest {
         return mailboxName;
     }
 
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("mailboxName", mailboxName)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/ListRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/ListRequest.java
index 31b73e5..e2e5e78 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/ListRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/ListRequest.java
@@ -21,6 +21,8 @@ package org.apache.james.imap.message.request;
 import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 
+import com.google.common.base.MoreObjects;
+
 public class ListRequest extends AbstractImapRequest {
     private final String baseReferenceName;
 
@@ -39,4 +41,12 @@ public class ListRequest extends AbstractImapRequest {
     public final String getMailboxPattern() {
         return mailboxPattern;
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("baseReferenceName", baseReferenceName)
+            .add("mailboxPattern", mailboxPattern)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/ListRightsRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/ListRightsRequest.java
index e63312f..a4e406f 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/ListRightsRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/ListRightsRequest.java
@@ -22,6 +22,8 @@ package org.apache.james.imap.message.request;
 import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 
+import com.google.common.base.MoreObjects;
+
 /**
  * LISTRIGHTS Request.
  */
@@ -43,4 +45,11 @@ public class ListRightsRequest extends AbstractImapRequest {
         return mailboxName;
     }
 
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("identifier", identifier)
+            .add("mailboxName", mailboxName)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/LoginRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/LoginRequest.java
index ed14d73..4a92b52 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/LoginRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/LoginRequest.java
@@ -23,6 +23,8 @@ import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 import org.apache.james.imap.api.message.request.ImapRequest;
 
+import com.google.common.base.MoreObjects;
+
 /**
  * {@link ImapRequest} which requests the login of a user
  */
@@ -54,4 +56,11 @@ public class LoginRequest extends AbstractImapRequest {
     public final Username getUserid() {
         return userid;
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("userid", userid)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/LsubRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/LsubRequest.java
index 7113dbf..dff4d7b 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/LsubRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/LsubRequest.java
@@ -21,6 +21,8 @@ package org.apache.james.imap.message.request;
 import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 
+import com.google.common.base.MoreObjects;
+
 public class LsubRequest extends AbstractImapRequest {
     private final String baseReferenceName;
 
@@ -39,4 +41,12 @@ public class LsubRequest extends AbstractImapRequest {
     public final String getMailboxPattern() {
         return mailboxPattern;
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("baseReferenceName", baseReferenceName)
+            .add("mailboxPattern", mailboxPattern)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/MoveRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/MoveRequest.java
index 0d303f1..c0c03af 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/MoveRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/MoveRequest.java
@@ -24,6 +24,8 @@ import org.apache.james.imap.api.Tag;
 import org.apache.james.imap.api.message.IdRange;
 import org.apache.james.imap.api.message.request.ImapRequest;
 
+import com.google.common.base.MoreObjects;
+
 /**
  * {@link ImapRequest} which request the move of messages
  */
@@ -33,4 +35,12 @@ public class MoveRequest extends AbstractMessageRangeRequest {
         super(ImapConstants.MOVE_COMMAND, idSet, mailboxName, useUids, tag);
     }
 
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("idSet", getIdSet())
+            .add("mailboxName", getMailboxName())
+            .add("useUids", isUseUids())
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/MyRightsRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/MyRightsRequest.java
index fa6f2d0..421024b 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/MyRightsRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/MyRightsRequest.java
@@ -22,6 +22,8 @@ package org.apache.james.imap.message.request;
 import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 
+import com.google.common.base.MoreObjects;
+
 /**
  * MYRIGHTS Request.
  */
@@ -36,4 +38,11 @@ public class MyRightsRequest extends AbstractImapRequest {
     public String getMailboxName() {
         return mailboxName;
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("mailboxName", mailboxName)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/RenameRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/RenameRequest.java
index 984a4e3..4d24475 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/RenameRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/RenameRequest.java
@@ -21,6 +21,8 @@ package org.apache.james.imap.message.request;
 import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 
+import com.google.common.base.MoreObjects;
+
 public class RenameRequest extends AbstractImapRequest {
     private final String existingName;
     private final String newName;
@@ -38,4 +40,12 @@ public class RenameRequest extends AbstractImapRequest {
     public final String getNewName() {
         return newName;
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("existingName", existingName)
+            .add("newName", newName)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/SearchRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/SearchRequest.java
index 6fa9176..df5ba78 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/SearchRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/SearchRequest.java
@@ -22,6 +22,8 @@ import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 import org.apache.james.imap.api.message.request.SearchOperation;
 
+import com.google.common.base.MoreObjects;
+
 public class SearchRequest extends AbstractImapRequest {
     private final SearchOperation operation;
     private final boolean useUids;
@@ -39,4 +41,12 @@ public class SearchRequest extends AbstractImapRequest {
     public final boolean isUseUids() {
         return useUids;
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("operation", operation)
+            .add("useUids", useUids)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/SelectRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/SelectRequest.java
index d7b98ad..da11ea3 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/SelectRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/SelectRequest.java
@@ -23,8 +23,23 @@ import org.apache.james.imap.api.Tag;
 import org.apache.james.imap.api.message.IdRange;
 import org.apache.james.imap.api.message.UidRange;
 
+import com.google.common.base.MoreObjects;
+
 public class SelectRequest extends AbstractMailboxSelectionRequest {
     public SelectRequest(String mailboxName, boolean condstore, ClientSpecifiedUidValidity lastKnownUidValidity, Long knownModSeq, UidRange[] uidSet, UidRange[] knownUidSet, IdRange[] knownSequenceSet, Tag tag) {
         super(ImapConstants.SELECT_COMMAND, mailboxName, condstore, lastKnownUidValidity, knownModSeq, uidSet, knownUidSet, knownSequenceSet, tag);
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("mailboxName", getMailboxName())
+            .add("condstore", getCondstore())
+            .add("lastKnownUidValidity", getLastKnownUidValidity())
+            .add("knownModSeq", getKnownModSeq())
+            .add("uidSet", getUidSet())
+            .add("knownUidSet", getKnownUidSet())
+            .add("knownSequenceSet", getKnownSequenceSet())
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetACLRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetACLRequest.java
index 6364234..1b34bb6 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetACLRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetACLRequest.java
@@ -22,6 +22,8 @@ package org.apache.james.imap.message.request;
 import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 
+import com.google.common.base.MoreObjects;
+
 /**
  * SETACL Request.
  */
@@ -49,4 +51,12 @@ public class SetACLRequest extends AbstractImapRequest {
         return rights;
     }
 
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("identifier", identifier)
+            .add("mailboxName", mailboxName)
+            .add("rights", rights)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetAnnotationRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetAnnotationRequest.java
index d9dc574..8a4535f 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetAnnotationRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetAnnotationRequest.java
@@ -25,6 +25,7 @@ import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 import org.apache.james.mailbox.model.MailboxAnnotation;
 
+import com.google.common.base.MoreObjects;
 import com.google.common.collect.ImmutableList;
 
 public class SetAnnotationRequest extends AbstractImapRequest {
@@ -45,4 +46,11 @@ public class SetAnnotationRequest extends AbstractImapRequest {
         return mailboxAnnotations;
     }
 
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("mailboxName", mailboxName)
+            .add("mailboxAnnotations", mailboxAnnotations)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetQuotaRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetQuotaRequest.java
index 756c19e..6cff465 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetQuotaRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/SetQuotaRequest.java
@@ -79,4 +79,12 @@ public class SetQuotaRequest extends AbstractImapRequest {
     public String getQuotaRoot() {
         return quotaRoot;
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("quotaRoot", quotaRoot)
+            .add("resourceLimits", resourceLimits)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/StatusRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/StatusRequest.java
index 950a024..692e34c 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/StatusRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/StatusRequest.java
@@ -22,6 +22,8 @@ import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 import org.apache.james.imap.api.message.StatusDataItems;
 
+import com.google.common.base.MoreObjects;
+
 public class StatusRequest extends AbstractImapRequest {
     private final String mailboxName;
 
@@ -40,4 +42,12 @@ public class StatusRequest extends AbstractImapRequest {
     public final StatusDataItems getStatusDataItems() {
         return statusDataItems;
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("mailboxName", mailboxName)
+            .add("statusDataItems", statusDataItems)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/SubscribeRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/SubscribeRequest.java
index 828c5aa..ddaf5f4 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/SubscribeRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/SubscribeRequest.java
@@ -21,6 +21,8 @@ package org.apache.james.imap.message.request;
 import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 
+import com.google.common.base.MoreObjects;
+
 public class SubscribeRequest extends AbstractImapRequest {
     private final String mailboxName;
 
@@ -32,4 +34,11 @@ public class SubscribeRequest extends AbstractImapRequest {
     public final String getMailboxName() {
         return mailboxName;
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("mailboxName", mailboxName)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/UnselectRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/UnselectRequest.java
index 7d89894..b87a422 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/UnselectRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/UnselectRequest.java
@@ -21,8 +21,16 @@ package org.apache.james.imap.message.request;
 import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 
+import com.google.common.base.MoreObjects;
+
 public class UnselectRequest extends AbstractImapRequest {
     public UnselectRequest(Tag tag) {
         super(tag, ImapConstants.UNSELECT_COMMAND);
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .toString();
+    }
 }
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/UnsubscribeRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/UnsubscribeRequest.java
index f585c74..21c287a 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/UnsubscribeRequest.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/UnsubscribeRequest.java
@@ -21,6 +21,8 @@ package org.apache.james.imap.message.request;
 import org.apache.james.imap.api.ImapConstants;
 import org.apache.james.imap.api.Tag;
 
+import com.google.common.base.MoreObjects;
+
 public class UnsubscribeRequest extends AbstractImapRequest {
     private final String mailboxName;
 
@@ -32,4 +34,11 @@ public class UnsubscribeRequest extends AbstractImapRequest {
     public final String getMailboxName() {
         return mailboxName;
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("mailboxName", mailboxName)
+            .toString();
+    }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org