You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/06/14 03:01:25 UTC
Review Request 70857: Added the test
`ROOT_DisallowShareAgentIPCNamespace`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70857/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-9788
https://issues.apache.org/jira/browse/MESOS-9788
Repository: mesos
Description
-------
Added the test `ROOT_DisallowShareAgentIPCNamespace`.
Diffs
-----
src/tests/containerizer/isolator_tests.cpp 9c14f3acbc19631b2f5cac4dc7cd9caba8527712
Diff: https://reviews.apache.org/r/70857/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 70857: Added the test
`ROOT_DisallowShareAgentIPCNamespace`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70857/#review216592
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On July 13, 2019, 1:22 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70857/
> -----------------------------------------------------------
>
> (Updated July 13, 2019, 1:22 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9788
> https://issues.apache.org/jira/browse/MESOS-9788
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the test `ROOT_DisallowShareAgentIPCNamespace`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp bb2cda47ad1fdd7ad16c419eb04f2e0b9293d2b6
>
>
> Diff: https://reviews.apache.org/r/70857/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70857: Added the test
`ROOT_DisallowShareAgentIPCNamespace`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70857/
-----------------------------------------------------------
(Updated July 13, 2019, 4:22 p.m.)
Review request for mesos, Andrei Budnik and Gilbert Song.
Changes
-------
Minor change.
Bugs: MESOS-9788
https://issues.apache.org/jira/browse/MESOS-9788
Repository: mesos
Description
-------
Added the test `ROOT_DisallowShareAgentIPCNamespace`.
Diffs (updated)
-----
src/tests/containerizer/isolator_tests.cpp bb2cda47ad1fdd7ad16c419eb04f2e0b9293d2b6
Diff: https://reviews.apache.org/r/70857/diff/2/
Changes: https://reviews.apache.org/r/70857/diff/1-2/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 70857: Added the test
`ROOT_DisallowShareAgentIPCNamespace`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70857/#review215893
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70773, 70774, 70775, 70798, 70844, 70820, 70845, 70849, 70852, 70857]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 14, 2019, 3:01 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70857/
> -----------------------------------------------------------
>
> (Updated June 14, 2019, 3:01 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9788
> https://issues.apache.org/jira/browse/MESOS-9788
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the test `ROOT_DisallowShareAgentIPCNamespace`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp 9c14f3acbc19631b2f5cac4dc7cd9caba8527712
>
>
> Diff: https://reviews.apache.org/r/70857/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>