You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "waynexia (via GitHub)" <gi...@apache.org> on 2023/11/02 03:23:51 UTC
[PR] fix: clippy warnings from nightly rust 1.75 [arrow-datafusion]
waynexia opened a new pull request, #8025:
URL: https://github.com/apache/arrow-datafusion/pull/8025
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Find these warnings after syncing my local toolchain
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Some minor lint fixes
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: clippy warnings from nightly rust 1.75 [arrow-datafusion]
Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum commented on code in PR #8025:
URL: https://github.com/apache/arrow-datafusion/pull/8025#discussion_r1379810867
##########
datafusion/core/tests/fuzz_cases/aggregate_fuzz.rs:
##########
@@ -36,6 +36,7 @@ use datafusion_physical_expr::{AggregateExpr, PhysicalSortExpr};
use test_utils::add_empty_batches;
#[cfg(test)]
+#[allow(clippy::items_after_test_module)]
Review Comment:
TBH I don't understand why these are wrapped into a tests module at all, since this IS already an integration test file (lives under `tests`). So I think clippy is not wrong here: this is confusing.
Could you try to just erase the additional `mod tests` indirection?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: clippy warnings from nightly rust 1.75 [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #8025:
URL: https://github.com/apache/arrow-datafusion/pull/8025#discussion_r1380655421
##########
datafusion/core/tests/fuzz_cases/aggregate_fuzz.rs:
##########
@@ -36,6 +36,7 @@ use datafusion_physical_expr::{AggregateExpr, PhysicalSortExpr};
use test_utils::add_empty_batches;
#[cfg(test)]
+#[allow(clippy::items_after_test_module)]
Review Comment:
https://github.com/apache/arrow-datafusion/pull/8036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: clippy warnings from nightly rust 1.75 [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #8025:
URL: https://github.com/apache/arrow-datafusion/pull/8025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: clippy warnings from nightly rust 1.75 [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #8025:
URL: https://github.com/apache/arrow-datafusion/pull/8025#discussion_r1380653197
##########
datafusion/core/tests/fuzz_cases/aggregate_fuzz.rs:
##########
@@ -36,6 +36,7 @@ use datafusion_physical_expr::{AggregateExpr, PhysicalSortExpr};
use test_utils::add_empty_batches;
#[cfg(test)]
+#[allow(clippy::items_after_test_module)]
Review Comment:
I tried this suggestion and it works well. I will make a follow on PR to further simplify the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org