You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by kr...@apache.org on 2020/04/19 22:13:27 UTC

[lucene-solr] branch master updated: SOLR-13886: HDFSSyncSliceTest and SyncSliceTest started failing frequently

This is an automated email from the ASF dual-hosted git repository.

krisden pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/master by this push:
     new 89e14fa  SOLR-13886: HDFSSyncSliceTest and SyncSliceTest started failing frequently
89e14fa is described below

commit 89e14faca95259269b651164d952cc32d74fe9b3
Author: Kevin Risden <kr...@apache.org>
AuthorDate: Sat Apr 18 13:45:54 2020 -0400

    SOLR-13886: HDFSSyncSliceTest and SyncSliceTest started failing frequently
    
    Signed-off-by: Kevin Risden <kr...@apache.org>
---
 solr/CHANGES.txt                                                     | 2 ++
 solr/core/src/test/org/apache/solr/cloud/SyncSliceTest.java          | 1 +
 solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsSyncSliceTest.java | 2 --
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index 3cb7fe9..9f3bdc8 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -167,6 +167,8 @@ Other Changes
 * SOLR-14391: Removed internal-ish ScoreFilter marker interface; only used by {!collapse}.  Removed needless code in
   SolrIndexSearcher.getDocSet(List<Query>) (processes some filter queries).  (David Smiley)
 
+* SOLR-13886: HDFSSyncSliceTest and SyncSliceTest started failing frequently (Kevin Risden)
+
 ==================  8.5.1 ==================
 
 Consult the LUCENE_CHANGES.txt file for additional, low level, changes in this release.
diff --git a/solr/core/src/test/org/apache/solr/cloud/SyncSliceTest.java b/solr/core/src/test/org/apache/solr/cloud/SyncSliceTest.java
index 37a7015..4394eb1 100644
--- a/solr/core/src/test/org/apache/solr/cloud/SyncSliceTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/SyncSliceTest.java
@@ -130,6 +130,7 @@ public class SyncSliceTest extends AbstractFullDistribZkTestBase {
     // this doc won't be on one node
     indexDoc(skipServers, id, docId++, i1, 50, tlong, 50, t1,
         "to come to the aid of their country.");
+    commit();
     
     
     Set<CloudJettyRunner> jetties = new HashSet<>();
diff --git a/solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsSyncSliceTest.java b/solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsSyncSliceTest.java
index 48e6d24..a2ed4f8 100644
--- a/solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsSyncSliceTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsSyncSliceTest.java
@@ -33,7 +33,6 @@ import com.carrotsearch.randomizedtesting.annotations.ThreadLeakFilters;
 @ThreadLeakFilters(defaultFilters = true, filters = {
     BadHdfsThreadsFilter.class // hdfs currently leaks thread(s)
 })
-// commented out on: 24-Dec-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 12-Jun-2018
 public class HdfsSyncSliceTest extends SyncSliceTest {
   private static MiniDFSCluster dfsCluster;
   
@@ -55,5 +54,4 @@ public class HdfsSyncSliceTest extends SyncSliceTest {
   protected String getDataDir(String dataDir) throws IOException {
     return HdfsTestUtil.getDataDir(dfsCluster, dataDir);
   }
-
 }