[jira] [Commented] (HDFS-15546) Remove duplicate initializeGenericKeys method when creating DFSZKFailoverController

["jianghua zhu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186461#comment-17186461 ] 

jianghua zhu commented on HDFS-15546:
-------------------------------------

[~elgoiri] , [~hexiaoqiao] , here is a patch file (HDFS-15546.001.patch), can you help review the code?

 

> Remove duplicate initializeGenericKeys method when creating DFSZKFailoverController
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-15546
>                 URL: https://issues.apache.org/jira/browse/HDFS-15546
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: jianghua zhu
>            Assignee: jianghua zhu
>            Priority: Major
>             Fix For: 3.3.0
>
>         Attachments: HDFS-15546.001.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When calling the DFSZKFailoverController#create() method, call NameNode#initializeGenericKeys() twice.
> First call:
> DFSZKFailoverController#create() {
> ...
> NameNode.initializeGenericKeys(localNNConf, nsId, nnId);
> ...
> }
> The second call:
> NNHAServiceTarget construction method:
> NNHAServiceTarget() {
> ...
> NameNode.initializeGenericKeys(targetConf, nsId, nnId);
> ...
> }
> In fact, the parameters passed in the two calls are the same. Here you can remove the first call without affecting the program itself.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org