You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2024/05/03 11:00:53 UTC
[PR] [MINVOKER-364] Rename invoker.systemPropertiesFile to invoker.userPropertiesFile [maven-invoker-plugin]
slawekjaranowski opened a new pull request, #235:
URL: https://github.com/apache/maven-invoker-plugin/pull/235
https://issues.apache.org/jira/browse/MINVOKER-364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINVOKER-364] Rename invoker.systemPropertiesFile to invoker.userPropertiesFile [maven-invoker-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #235:
URL: https://github.com/apache/maven-invoker-plugin/pull/235#issuecomment-2092890200
exactly it are a `user properties` passed by `-D` Maven argument
we have:
```
MAVEN_OPTS='-DsysProperty=xxx' mvn ... -DuserProperty=xxx
```
so `userProperty` it is a user property pass to Maven as cli argument
We cen set a system property by `MAVEN_OPTS` environment variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINVOKER-364] Rename invoker.systemPropertiesFile to invoker.userPropertiesFile [maven-invoker-plugin]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #235:
URL: https://github.com/apache/maven-invoker-plugin/pull/235#issuecomment-2092849630
not sure I understand this naming change,
At the end of the day, those properties will be system properties used to fork the Maven invocation.
So they are the system properties of the Maven invocation you want to run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINVOKER-364] Rename invoker.systemPropertiesFile to invoker.userPropertiesFile [maven-invoker-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #235:
URL: https://github.com/apache/maven-invoker-plugin/pull/235#issuecomment-2092931481
> not sure I understand this naming change, At the end of the day, those properties will be system properties used to fork the Maven invocation. So they are the system properties of the Maven invocation you want to run. you are confusing with Maven core naming but for an end user POV they are system properties. Those one you set using `-D...` when using the command line.
This has been a mess created long time ago. We need to clean up. Maven should use for itself user props only. If the JVM requires sys props they need to be set *before* Maven invocation. `System.setProperty()` cannot guarantee that the actual property is picked up by the receiver. Some read only at startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINVOKER-364] Rename invoker.systemPropertiesFile to invoker.userPropertiesFile [maven-invoker-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #235:
URL: https://github.com/apache/maven-invoker-plugin/pull/235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINVOKER-364] Rename invoker.systemPropertiesFile to invoker.userPropertiesFile [maven-invoker-plugin]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #235:
URL: https://github.com/apache/maven-invoker-plugin/pull/235#issuecomment-2957825862
Resolve #592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org