You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "ruanwenjun (via GitHub)" <gi...@apache.org> on 2026/05/12 15:03:46 UTC
[PR] [Improvement-18249][DAO] Route ScheduleMapper access through ScheduleDao [dolphinscheduler]
ruanwenjun opened a new pull request, #18251:
URL: https://github.com/apache/dolphinscheduler/pull/18251
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Was this PR generated or assisted by AI?
YES, ops 4.7
## Purpose of the pull request
Tracking issue: #18249
Expose the methods the api layer needs on ScheduleDao (queryByWorkflowDefinitionCode, querySchedulerListByProjectName, queryByProjectAndWorkflowDefinitionCodePaging, querySchedulesByWorkflowDefinitionCodes, queryScheduleListByTenant, queryScheduleByWorkerGroup) and replace every direct ScheduleMapper reference in dolphinscheduler-api with the Dao, so Mapper usage stays inside dolphinscheduler-dao.repository as documented in dolphinscheduler-dao/CLAUDE.md.
Notes:
- BaseDao#deleteById and BaseDao#updateById return boolean (Mapper returned int). Affected call sites in SchedulerServiceImpl and WorkflowDefinitionServiceImpl were adapted (boolean delete = scheduleDao.deleteById(id); if (!delete)). Test mocks switched from thenReturn(1/0) to thenReturn(true/false).
- selectById was replaced with the IDao#queryById equivalent.
- WorkerGroupServiceImpl previously inlined a BaseMapper.selectList(QueryWrapper) to find schedules referencing a worker group; the QueryWrapper is now encapsulated as ScheduleDao#queryScheduleByWorkerGroup so the api layer no longer constructs a raw QueryWrapper for this lookup.
No production behavior changes; the Mapper interface itself is untouched.
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
## Pull Request Notice
[Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
If your pull request contains incompatible change, you should also add it to `docs/docs/en/guide/upgrade/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-18249][DAO] Route ScheduleMapper access through ScheduleDao [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #18251:
URL: https://github.com/apache/dolphinscheduler/pull/18251#issuecomment-4432280863
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18251) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=18251&metric=new_coverage&view=list) (required ≥ 60%)
<!-- sqra:qg_revision=184a56e79b09572a8f677db63e8a15842bedec63279916924e37cd83e67fccc8 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18251)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-18249][DAO] Route ScheduleMapper access through ScheduleDao [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #18251:
URL: https://github.com/apache/dolphinscheduler/pull/18251#issuecomment-4447048040
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18251) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=18251&metric=new_coverage&view=list) (required ≥ 60%)
<!-- sqra:qg_revision=184a56e79b09572a8f677db63e8a15842bedec63279916924e37cd83e67fccc8 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=18251)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-18249][DAO] Route ScheduleMapper access through ScheduleDao [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS merged PR #18251:
URL: https://github.com/apache/dolphinscheduler/pull/18251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org