[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #14162: Fix master memory leak due to MasterTaskExecuteRunnableDoesn't be removed

["caishunfeng (via GitHub)" <gi...@apache.org>]

caishunfeng commented on code in PR #14162:
URL: https://github.com/apache/dolphinscheduler/pull/14162#discussion_r1199585158


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/execute/MasterTaskExecuteRunnable.java:
##########
@@ -59,7 +58,7 @@ public MasterTaskExecuteRunnable(TaskExecutionContext taskExecutionContext,
     protected void afterThrowing(Throwable throwable) {
         try {
             cancelTask();
-            log.info("Get a exception when execute the task, canceled the task");
+            log.info("Get a exception when execute the task, canceled the task", throwable);

Review Comment:
   ```suggestion
               log.error("Get a exception when execute the task, canceled the task", throwable);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org