[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1685: docs: tells users where they are

[GitBox <gi...@apache.org>]

juzhiyuan commented on a change in pull request #1685:
URL: https://github.com/apache/apisix-dashboard/pull/1685#discussion_r603694459



##########
File path: web/src/locales/zh-CN/component.ts
##########
@@ -21,19 +21,24 @@ export default {
   'component.global.search': '查询',
   'component.global.reset': '重置',
   'component.global.confirm': '确认',
+  'component.global.format': '格式',

Review comment:
       ```suggestion
     'component.global.format': '格式化',
   ```

##########
File path: docs/en/latest/config.json
##########
@@ -1,6 +1,11 @@
 {
   "version": 2.4,
   "sidebar": [
+    {
+      "type": "link",
+      "label": "Apache Apisix Dashboard",

Review comment:
       ```suggestion
         "label": "Apache APISIX Dashboard",
   ```

##########
File path: web/src/locales/zh-CN/component.ts
##########
@@ -21,19 +21,24 @@ export default {
   'component.global.search': '查询',
   'component.global.reset': '重置',
   'component.global.confirm': '确认',
+  'component.global.format': '格式',
+  'component.global.document': '文档',
+  'component.global.enable': '使能够',
+  'component.global.scope': '范围',
+  'component.global.data.editor': '资料编辑器',

Review comment:
       ```suggestion
     'component.global.data.editor': '元数据编辑器',
   ```

##########
File path: web/src/pages/Plugin/locales/en-US.ts
##########
@@ -16,5 +16,7 @@
  */
 export default {
   'page.plugin.drawer.popconfirm.title.delete': 'Are you sure to delete this item?',
-  'page.plugin.list': 'Plugin List'
+  'page.plugin.list': 'Plugin List',
+  'page.plugin.list.enabled': 'List of enabled plugins',
+  'page.plugin.market.config': 'Config Plugin',

Review comment:
       Not sure to use `config` or `configure`?

##########
File path: web/src/locales/zh-CN/component.ts
##########
@@ -21,19 +21,24 @@ export default {
   'component.global.search': '查询',
   'component.global.reset': '重置',
   'component.global.confirm': '确认',
+  'component.global.format': '格式',
+  'component.global.document': '文档',
+  'component.global.enable': '使能够',
+  'component.global.scope': '范围',
+  'component.global.data.editor': '资料编辑器',
   'component.global.delete': '删除',
   'component.global.cancel': '取消',
   'component.global.submit': '提交',
   'component.global.create': '创建',
   'component.global.createWithEditor': '使用编辑器创建',
   'component.global.add': '新建',
   'component.global.save': '保存',
-  'component.global.edit': '编辑',
+  'component.global.edit': '配置',

Review comment:
       actually, it's more clear to use `编辑` 😂
   
   ```suggestion
     'component.global.edit': '编辑',
   ```

##########
File path: web/src/pages/Plugin/PluginMarket.tsx
##########
@@ -20,6 +20,7 @@ import { PageHeaderWrapper } from '@ant-design/pro-layout';
 
 import PluginPage from '@/components/Plugin';
 import { fetchList, createOrUpdate } from './service';
+import { formatMessage } from 'umi';

Review comment:
       ok, we need to use
   
   ```suggestion
   import { useIntl } from 'umi';
   ```
   
   here, and use `const { formatMessage } = useIntl()`

##########
File path: web/src/locales/zh-CN/component.ts
##########
@@ -21,19 +21,24 @@ export default {
   'component.global.search': '查询',
   'component.global.reset': '重置',
   'component.global.confirm': '确认',
+  'component.global.format': '格式',
+  'component.global.document': '文档',
+  'component.global.enable': '使能够',

Review comment:
       ```suggestion
     'component.global.enable': '启用',
   ```

##########
File path: web/src/locales/zh-CN/component.ts
##########
@@ -21,19 +21,24 @@ export default {
   'component.global.search': '查询',
   'component.global.reset': '重置',
   'component.global.confirm': '确认',
+  'component.global.format': '格式',
+  'component.global.document': '文档',
+  'component.global.enable': '使能够',
+  'component.global.scope': '范围',

Review comment:
       ```suggestion
     'component.global.scope': '作用域',
   ```

##########
File path: web/src/pages/Service/Create.tsx
##########
@@ -116,7 +116,7 @@ const Page: React.FC = (props) => {
     <>
       <PageHeaderWrapper
         title={`${
-          (props as any).match.params.rid
+          (props as any).match.params.serviceId

Review comment:
       Do we have `serviceId`? cc @nic-chen 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org