[GitHub] [ozone] GlenGeng commented on a change in pull request #2157: HDDS-5107. Add trace for containerReport

[GitBox <gi...@apache.org>]

GlenGeng commented on a change in pull request #2157:
URL: https://github.com/apache/ozone/pull/2157#discussion_r613731514



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerReportHandler.java
##########
@@ -118,6 +121,9 @@ public void onMessage(final ContainerReportFromDatanode reportFromDatanode,
     try {
       final List<ContainerReplicaProto> replicas =
           containerReport.getReportsList();
+      LOG.trace("begin processing ContainerReport of {} at {}," +

Review comment:
       Please use `LOG.info` instead.

##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerReportHandler.java
##########
@@ -144,7 +150,9 @@ public void onMessage(final ContainerReportFromDatanode reportFromDatanode,
       LOG.error("Received container report from unknown datanode {}.",
           datanodeDetails, ex);
     }
-
+    LOG.trace("complete processing ContainerReport of {} at {}" +
+        "and processedContainerReportCount is {}", datanodeDetails.getUuid(),
+        Time.now(), processedContaienReportCount.addAndGet(1L));

Review comment:
       Please calculate the latency and add to the `LOF.info` as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org