You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/11 08:22:08 UTC
[GitHub] [maven-integration-testing] MartinKanters opened a new pull request, #209: [MNG-7338] Disable CI mode for certain tests which verify on log statements.
MartinKanters opened a new pull request, #209:
URL: https://github.com/apache/maven-integration-testing/pull/209
Relevant [Maven PR](https://github.com/apache/maven/pull/869)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on pull request #209: [MNG-7338] Disable CI mode for certain tests which verify on log statements.
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on PR #209:
URL: https://github.com/apache/maven-integration-testing/pull/209#issuecomment-1320187938
> > I agree. I tried to remove it using `verifier.getEnvironmentVariables().remove( "CI" );`, but that doesn't work unfortunately.
>
> Should work with:
>
> ```
> verifier.addEnvironemnt( "CI", null );
> ```
>
> but needs a maven-sahred-utils 3.3.4 ... as I see 0.9 is used in tests 😄
Right.. not sure if that's worth the effort for this change haha. I tried it quickly but didn't see an addEnvironment variable method. I did see that invoking setEnvironment with a `null` value should remove it from the environment variables. But that didn't work before. I think that's because those environment vars are probably merged later with the actual environment variables (which would add CI=true again)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #209: [MNG-7338] Disable CI mode for certain tests which verify on log statements.
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #209:
URL: https://github.com/apache/maven-integration-testing/pull/209#issuecomment-1311725822
> I agree. I tried to remove it using `verifier.getEnvironmentVariables().remove( "CI" );`, but that doesn't work unfortunately.
Should work with:
```
verifier.addEnvironemnt( "CI", null );
```
but needs a maven-sahred-utils 3.3.4 ... as I see 0.9 is used in tests 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on pull request #209: [MNG-7338] Disable CI mode for certain tests which verify on log statements.
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on PR #209:
URL: https://github.com/apache/maven-integration-testing/pull/209#issuecomment-1311390498
> I don't really think it is not in the spirit of this var. As far as I understand it is either `CI=true` or not present at all.
I agree. I tried to remove it using `verifier.getEnvironmentVariables().remove( "CI" );`, but that doesn't work unfortunately.
I would not like to change the actual environment variables on the machine if possible, so I thought this was the best way forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on pull request #209: [MNG-7338] Disable CI mode for certain tests which verify on log statements.
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #209:
URL: https://github.com/apache/maven-integration-testing/pull/209#issuecomment-1311380814
I don't really think it is not in the spirit of this var. As far as I understand it is either `CI=true` or not present at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] rmannibucau commented on pull request #209: [MNG-7338] Disable CI mode for certain tests which verify on log statements.
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #209:
URL: https://github.com/apache/maven-integration-testing/pull/209#issuecomment-1311417178
@michael-o it is the defined semantic now but was not originally and it was soletimes used to switch between vendors. That said can not be critical due to the impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] gnodet merged pull request #209: [MNG-7338] Disable CI mode for certain tests which verify on log statements.
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #209:
URL: https://github.com/apache/maven-integration-testing/pull/209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org